Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Img Tag Refactor #4383 #4524

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Img Tag Refactor #4383 #4524

merged 1 commit into from
Apr 19, 2023

Conversation

graycodesnu
Copy link
Member

Fixes #4383

What changes did you make and why did you make them ?

  • Changed an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b graycodesnu-img-tag--4383 gh-pages
git pull https://github.com/graycodesnu/hfla-website.git img-tag--4383

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Getting Started https://www.hackforla.org/getting-started Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 16, 2023
@graycodesnu graycodesnu mentioned this pull request Apr 16, 2023
Closed
@graycodesnu
Copy link
Member Author

Originally from #4521

@kwangric kwangric self-requested a review April 17, 2023 03:16
@kwangric
Copy link
Member

ETA: EOD 4/17
Availability: After 1pm PDT 4/17

@steven-positive-tran
Copy link
Member

ETA: EOD 4/17
Availability: 9pm -12am PST 4/16, 4/17

@Jaretzbalba Jaretzbalba self-requested a review April 17, 2023 15:34
@Jaretzbalba
Copy link
Member

ETA: EOD 4/17
Availability: 1 hour

Jaretzbalba
Jaretzbalba approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@Jaretzbalba Jaretzbalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graycodesnu I see that the img tag was corrected by removing the ending slash to keep our codebase consistent. Thank you for working on this first good issue!

kwangric
kwangric approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches were set up correctly. The requested changes were made and everything looks good in Docker. The pull request also states what changes were made and why. Great work!

@steven-positive-tran steven-positive-tran self-requested a review April 18, 2023 04:16
steven-positive-tran
steven-positive-tran approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@steven-positive-tran steven-positive-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Branches look good
  • PR gave a good summary of the changes
  • Looks good on my machine
  • Code changes seems in line with the issue

Approved and thank you for taking up this issue.

@angieyan angieyan self-requested a review April 18, 2023 16:37
@angieyan
Copy link
Member

ETA: 4/18/23
Availability: 10am-3pm

@chrismenke45 chrismenke45 merged commit fce793a into hackforla:gh-pages Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaretzbalba Jaretzbalba Jaretzbalba approved these changes

@steven-positive-tran steven-positive-tran steven-positive-tran approved these changes

@kwangric kwangric kwangric approved these changes

@angieyan angieyan angieyan approved these changes

Assignees
No one assigned
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Getting Started https://www.hackforla.org/getting-started role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: Getting Started page - step-img-wide solidarity.png
6 participants
@graycodesnu @kwangric @steven-positive-tran @Jaretzbalba @angieyan @chrismenke45