-
-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed sdg-img-item class #4518
removed sdg-img-item class #4518
Conversation
Review ETA: 9:00 PM CST 4/15/23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Krista! I read over your PR. Everything looks good! You made sure to link the issue and that the change originates from the feature branch, removed the requested lines of code, and stated the reason for the change. Only thing I might suggest in the future is avoiding the extra white space changes as they tend to clutter the PR. Other than that small suggestion, great job!
ETA 4/14/23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kurikurichan, great job listing the changes you made and why you did them. The PR is linked to its issue; however, please don't forget to move your PR to the Project Board.
Commit change approved! Nicely done!
Hi @kurikurichan please move the PR to the Project Board, and we will get it merged. Thank you ! |
Thank you!! I will do that now |
Hi @kurikurichan, one last thing! Could you add the same labels in issue #4422 on this pull request? The labels are usually automatically added by the github actions bot. It wasn't added this time since this pull request wasn't added to the project board on creation. |
Thanks @Adastros, I did that just now. For future reference, is there a way I should add the pull request to the project board on creation? |
Hi @kurikurichan, thanks for adding the labels! You can add the pull request before submitting it by clicking the gear icon as shown below. Previously I mentioned adding the pull request to the project board before submitting but you can do it after or before. Thinking about it more, the labels probably weren't added automatically due to some changes to the project board that occurred around the time you submitted the pull request. Those changes caused some issues with the bots. You can check the details for this merge and see one of the errors for this pull request. It also helps to double check the labels just in case the bots didn't add them. Reference this section of contributing.md for adding the pull request to the project board. |
Fixes #4422
What changes did you make and why did you make them ?