Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored img HTML tag in pages/events.html #4497

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

wKategianes
Copy link
Member

Fixes #4445

What changes did you make and why did you make them ?

  • I changed an img HTML tag that was ending in a slash (<img.../>) to an img tag without a slash (<img...>).
  • The file that was worked on was inside pages/events.html and now the img HTML tag is now consistent with the codebase.
<img class="vector-img" src="../assets/images/hack-nights/locations.svg" alt="" />

to

<img class="vector-img" src="../assets/images/hack-nights/locations.svg" alt="" >

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b wKategianes-refactor-img-tag-4445 gh-pages
git pull https://github.com/wKategianes/website.git refactor-img-tag-4445

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Events https://www.hackforla.org/events/ Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 13, 2023
@karengcecena karengcecena self-requested a review April 13, 2023 16:44
@karengcecena
Copy link
Member

ETA: 10am on 4/13
Availability: 9-10 am 4/13

karengcecena
karengcecena previously approved these changes Apr 13, 2023
Copy link
Member

@karengcecena karengcecena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, wKategianes. Thank you for taking the time to complete this issue. Your pull request is to and from the correct branches, you linked the issue correctly, you removed the slash that was asked for, and the website looks good on my local machine.

Great job & thanks again for working on this issue!

@LOSjr4 LOSjr4 self-requested a review April 13, 2023 17:41
@LOSjr4
Copy link
Member

LOSjr4 commented Apr 13, 2023

Availability: M,T,TH 9AM-1PM
ETA: today noon

Copy link
Member

@LOSjr4 LOSjr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although it doesn't affect anything, the instructions on the original issue had no space after (alt=""> instead of alt="" >). The correct slash was removed which is most important, but also removing the space would be perfection.

@blulady
Copy link
Member

blulady commented Apr 13, 2023

@wKategianes looks like a very clean first issue, Good Job!! However in the interests of uniformity in the website could you modify the PR as @LOSjr4 suggested and eliminate that extra space. Like he says, it has no real effect but it will drive some of the other Devs bananas.

@StephenTheDev1001 StephenTheDev1001 requested review from StephenTheDev1001 and removed request for StephenTheDev1001 April 14, 2023 05:58
@angieyan
Copy link
Member

Review ETA: 4/18/2023
Availability: 1-3 PM

Copy link
Member

@angieyan angieyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @wKategianes! You have done everything correctly.

@blulady blulady requested review from LOSjr4 and karengcecena April 19, 2023 02:28
Copy link
Member

@karengcecena karengcecena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, wKategianes. Thank you going back and implementing the feedback LOSjr4 left you. Both the slash and space are removed now.

And like before, your pull request is still to and from the correct branches, the issue is linked correctly and the website looks good on my end.

Great job again!

Copy link
Member

@LOSjr4 LOSjr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I received notification that this is ready for re-review. I see perfection. Thank you @wKategianes for going back and taking out that space.

@chrismenke45 chrismenke45 merged commit a4add9b into hackforla:gh-pages Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Events https://www.hackforla.org/events/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: Events page(s)
6 participants