-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored img HTML tag in pages/events.html #4497
Refactored img HTML tag in pages/events.html #4497
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: 10am on 4/13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, wKategianes. Thank you for taking the time to complete this issue. Your pull request is to and from the correct branches, you linked the issue correctly, you removed the slash that was asked for, and the website looks good on my local machine.
Great job & thanks again for working on this issue!
Availability: M,T,TH 9AM-1PM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it doesn't affect anything, the instructions on the original issue had no space after (alt=""> instead of alt="" >). The correct slash was removed which is most important, but also removing the space would be perfection.
@wKategianes looks like a very clean first issue, Good Job!! However in the interests of uniformity in the website could you modify the PR as @LOSjr4 suggested and eliminate that extra space. Like he says, it has no real effect but it will drive some of the other Devs bananas. |
Review ETA: 4/18/2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @wKategianes! You have done everything correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, wKategianes. Thank you going back and implementing the feedback LOSjr4 left you. Both the slash and space are removed now.
And like before, your pull request is still to and from the correct branches, the issue is linked correctly and the website looks good on my end.
Great job again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I received notification that this is ready for re-review. I see perfection. Thank you @wKategianes for going back and taking out that space.
Fixes #4445
What changes did you make and why did you make them ?
to