SDG 16: Rename and replace image with correct color one

[cng008]

Fixes #4253

What changes did you make and why did you make them ?

• Replaced the Sustainable Development Goals (SDG) images so that the SDG svgs are the correct color and follow the United Nations' SDG guidelines.
  • Deleted peace-justice.svg from the assets/images/sdg directory
  • Added sdg16.svg to the assets/images/sdg directory
• Updated the path to the SVG in the following files:
  • _includes/about-page/about-card-sustainability.html
  • _projects/311-data.md
  • _projects/access-the-data.md
  • _projects/engage.md
  • _projects/open-community-survey.md

Things to note:

• 311 Data: https://www.hackforla.org/projects/311-data
  • background of color is different now that the SVG image color has changed
• Access the Data: https://www.hackforla.org/projects/access-the-data
  • image does not exist on this page
• Engage: https://www.hackforla.org/projects/engage
  • background of color is different now that the SVG image color has changed
• Open Community Survey: https://www.hackforla.org/projects/open-community-survey
  • background of color is different now that the SVG image color has changed

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b cng008-replace-sdg-images-4253 gh-pages
git pull https://github.com/cng008/website.git replace-sdg-images-4253

[RyanGehris]

I noticed that there is a merge conflict in your code. Here is a resource on resolving merge conflicts that might be helpful. Please look into it, and then I will be able to approve your changes. Thank you for all the work you have done so far on this issue!

[cng008]

@RyanGehris Thanks for the heads up! I hope I was able to fix the merge conflict. Let me know if there are any issues.

[RyanGehris]

The merge conflicts look like they were resolved, but now there is no img element for sdg16.svg that is meant to replace peace-justice.svg in the file _includes/about-page/about-card-sustainability.html

Here are screenshots of what I am seeing when viewing https://www.hackforla.org/about/#sustainability on my local computer.

Current About Page

About Page after your changes

The changes you made to these pages are great!

• Citizen Engagement page: https://www.hackforla.org/citizen-engagement
• 311 Data: https://www.hackforla.org/projects/311-data
• Access the Data: https://www.hackforla.org/projects/access-the-data
• Engage: https://www.hackforla.org/projects/engage
• Open Community Survey: https://www.hackforla.org/projects/open-community-survey

[cng008]

@RyanGehris Good catch! I swear that was there when I merged it. I've added back the SVG, however the empty line at the end of the file was deleted for some reason. If this is an issue, let me know and I can try and fix it.

[RyanGehris]

Great work! The correct changes are made and the website looks as intended. Thank you for working on this issue!

[mademarc]

Review ETA: 4/20/2023
Availability: 7:15PM

[mademarc]

Hey @cng008 the svg image was added well on the img elements correctly and it looks good

[blulady]

Great work! The correct changes are made and the website looks as intended. Thank you for working on this issue!

Thanks for thoroughly reviewing this @RyanGehris, I appreciate your time. Do you mind leaving an approval in addition to your comment? Thank you!!!

[blulady]

@mademarc can you approve the PR in addition to your comment?

[LOSjr4]

Availability: M,T,TH 9AM-1PM
ETA: now

[LOSjr4]

I see all of the targeted peace-justice.svg where changed to sdg16.svg, and all of the new site pages appear the same as our current site albeit slightly scaled different which was expected.
I saw your note on the image not showing on _projects/access-the-data.md. That is a good observation. It is also true on our current website, so it's acceptable regarding what this issue requested. Good work @cng008 !

[LOSjr4]

@cng008 go ahead and click that Re-request review button next to the reviewers who have not left an "approval" yet, so they're alerted that your changes are ready to be re-checked.

[RyanGehris]

Great work! The correct changes are made and the website looks as intended. Thank you for working on this issue!

[RyanGehris]

@blulady Thank you for letting me know that I forgot to actually approve the changes. I just did it. Sorry about that.

[blulady]

I did not see the sdg16.svg on About page's Sustainability section: https://www.hackforla.org/about/#sustainability
Is it just me?

[mademarc]

Availability: 4/20/2023
ETA: 7:05pm

[mademarc]

Hey @blulady thank you for the heads up and as i have approved this also once again @cng008 good job on this.

[RyanGehris]

@blulady I am seeing the same thing as you when using firefox. I typically check on chrome, safari, and a mobile device so I did not notice that. The changes were successful for Chrome, Safari, and Mobile on my local computer.

[cng008]

Thank you @RyanGehris and @mademarc for approving again. It seems this PR keeps getting merge conflicts as other PRs are getting merged before this one. @blulady I will be OOO until Tuesday 4/25 and will look at it once again then.

[roslynwythe]

@cng008 It appears that on the live site there is a problem with the grid layout:

and resolving that problem is out of the scope of your issue, so we'll create an ER to manage that going forward.