-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trailing slash from <img> tag in Citizen Engagement page #4461
Remove trailing slash from <img> tag in Citizen Engagement page #4461
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Wasn't sure if I should remove the other <img> tag's trailing slash per the issue's instructions since it only mentioned the hero image's tag, but since this is for consistency across the code base, if I need to do add that one to the PR as well just let me know! 😄 |
Review ETA: 04/11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job working on this issue. The changes you made were correct, and you are right in that you only needed to update the img element for the hero image. I am requesting changes because in your pull request you should provide an explanation of why the changes were made. You can do this by adding another bullet point under the header "What changes did you make and why did you make them ?"
Thanks Ryan, the PR has been updated to include the reasoning from the original issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @cjmedina95!
- You made the changes that were outlined in the issue
- Made in the correct branch
- Linked issue
- Stated reason for the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you for adding an explanation for the changes you made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request is done in the correct branch and the issue is linked correctly. In the source code, I see the change was made to the image tag to remove the slash at the end. There are no visual changes made. Good job on your first issue!
Fixes #4447
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
(No visual changes)