Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash from <img> tag in Citizen Engagement page #4461

Merged

Conversation

cmedina-dev
Copy link
Contributor

@cmedina-dev cmedina-dev commented Apr 10, 2023

Fixes #4447

What changes did you make and why did you make them ?

  • Removed the trailing slash from the hero <img> tag.
  • The tag was removed to ensure consistency with other HTML <img> tags across the site.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

(No visual changes)

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b cjmedina95-citizen-engagement-refactor-4447 gh-pages
git pull https://github.com/cjmedina95/website.git citizen-engagement-refactor-4447

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Refactor HTML P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 10, 2023
@cmedina-dev
Copy link
Contributor Author

Wasn't sure if I should remove the other <img> tag's trailing slash per the issue's instructions since it only mentioned the hero image's tag, but since this is for consistency across the code base, if I need to do add that one to the PR as well just let me know! 😄

@arcan9 arcan9 self-requested a review April 11, 2023 17:43
@arcan9
Copy link
Member

arcan9 commented Apr 11, 2023

Review ETA: 04/11
Availability: after 5pm pst, M-F

@RyanGehris RyanGehris self-requested a review April 11, 2023 18:24
Copy link
Member

@RyanGehris RyanGehris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job working on this issue. The changes you made were correct, and you are right in that you only needed to update the img element for the hero image. I am requesting changes because in your pull request you should provide an explanation of why the changes were made. You can do this by adding another bullet point under the header "What changes did you make and why did you make them ?"

@cmedina-dev
Copy link
Contributor Author

Great job working on this issue. The changes you made were correct, and you are right in that you only needed to update the img element for the hero image. I am requesting changes because in your pull request you should provide an explanation of why the changes were made. You can do this by adding another bullet point under the header "What changes did you make and why did you make them ?"

Thanks Ryan, the PR has been updated to include the reasoning from the original issue.

@cmedina-dev cmedina-dev requested a review from RyanGehris April 11, 2023 19:06
Copy link
Member

@arcan9 arcan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @cjmedina95!

  • You made the changes that were outlined in the issue
  • Made in the correct branch
  • Linked issue
  • Stated reason for the change

Copy link
Member

@RyanGehris RyanGehris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you for adding an explanation for the changes you made.

@cng008 cng008 self-requested a review April 12, 2023 20:23
Copy link
Member

@cng008 cng008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request is done in the correct branch and the issue is linked correctly. In the source code, I see the change was made to the image tag to remove the slash at the end. There are no visual changes made. Good job on your first issue!

@jdingeman jdingeman merged commit 2751aa6 into hackforla:gh-pages Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: Citizen Engagement page
5 participants