Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sdg color vars 4233 #4403

Closed
wants to merge 2 commits into from
Closed

Add sdg color vars 4233 #4403

wants to merge 2 commits into from

Conversation

StephenTheDev1001
Copy link
Contributor

Fixes #4233

What changes did you make and why did you make them ?

  • create new file _colors-sdg.scss with sdg-color variables
  • import _colors-sdg.scss to _sass/main.scss
  • add this allows us to use these colors with their corresponding, matching SDG icons.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Added scss background color variables. No visual changes.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b StephenTheDev1001-add-sdg-color-vars-4233 gh-pages
git pull https://github.com/StephenTheDev1001/website.git add-sdg-color-vars-4233

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Apr 4, 2023
@StephenTheDev1001 StephenTheDev1001 deleted the add-sdg-color-vars-4233 branch April 4, 2023 04:05
@StephenTheDev1001 StephenTheDev1001 restored the add-sdg-color-vars-4233 branch April 4, 2023 04:50
@roslynwythe roslynwythe mentioned this pull request Jul 25, 2023
Open
73 tasks
@colin-macrae colin-macrae requested review from colin-macrae and removed request for colin-macrae March 15, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SDG color variables: 2-5, 8-11, 13, 16, 17
1 participant
@StephenTheDev1001