Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Img Tag Refactor in Getting Started Page #4402

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Img Tag Refactor in Getting Started Page #4402

merged 1 commit into from
Apr 4, 2023

Conversation

thedvo
Copy link
Member

@thedvo thedvo commented Apr 4, 2023

Fixes #4377

What changes did you make and why did you make them ?

  • Changed an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b thedvo-img-tag-refactor-4377 gh-pages
git pull https://github.com/thedvo/website.git img-tag-refactor-4377

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Getting Started https://www.hackforla.org/getting-started Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 4, 2023
cng008
cng008 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@cng008 cng008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request is done in the correct branch and the issue is linked correctly. In the source code, I see the change was made to the image tag to remove the slash at the end. There are no visual changes made. Good job on your first issue!

@hang-justin hang-justin self-requested a review April 4, 2023 08:01
@hang-justin
Copy link
Member

Review ETA: 4/4/23
Availability: 9-5 pacific time, weekdays

@hang-justin
Copy link
Member

The pull request was linked properly and the description is clear and concise. Great work!

@jdingeman jdingeman merged commit e75ac6f into hackforla:gh-pages Apr 4, 2023
@roslynwythe roslynwythe mentioned this pull request Jul 25, 2023
Open
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cng008 cng008 cng008 approved these changes

@hang-justin hang-justin hang-justin approved these changes

Assignees
No one assigned
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Getting Started https://www.hackforla.org/getting-started role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: Getting Started page - step-img-intro technology.png
4 participants
@thedvo @hang-justin @cng008 @jdingeman