Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed link value #4150

Merged

Conversation

ftblmagician
Copy link
Member

Fixes #4141

What changes did you make and why did you make them ?

We changed the self-invite link previously hosted by Heroku to the Hack for LA Slack channel. We made the change because the Heroku link is no longer active.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ftblmagician-update-selfinvite-link-4141 gh-pages
git pull https://github.com/ftblmagician/website.git update-selfinvite-link-4141

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Complexity: Good second issue Status: Updated No blockers and update is ready for review P-Feature: Footer size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 11, 2023
@jdingeman jdingeman requested a review from jefflueck March 12, 2023 17:28
@steven-positive-tran
Copy link
Member

Availability: 3/12 3-12pm
ETA EOD 3/12 8pm

@steven-positive-tran steven-positive-tran self-requested a review March 13, 2023 03:30
Copy link
Member

@steven-positive-tran steven-positive-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good branches look good, source code looks applicable and the website redirects me to the slack channel on my machine.

For those who want to check the changes are in the footer
image

Appove

@ftblmagician
Copy link
Member Author

Hi! Can I have this issue merged?

Thank you!

Copy link
Member

@jefflueck jefflueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I see the change and looks to be what was requested

@t-will-gillis t-will-gillis self-requested a review March 15, 2023 04:27
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ftblmagician - Great job! The changes are coming from / going to the correct branches, the changes address the linked issue with clean code and only the necessary changes. I checked in Docker and the link is working correctly.

Thanks for working on this!

@t-will-gillis t-will-gillis merged commit 02796a9 into hackforla:gh-pages Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Footer role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Updated No blockers and update is ready for review time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Self-Invite Link for the Slack Icon in the Footer of the Website
5 participants