-
-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the value of title and description in not-today.md #4121
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I love that you included screenshots for me to look at.
Availability (PST): 10:30 - 11PM 07MAR23, 9 - 11 PM 07MAR23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattmalane good job on completing the issue! The changes to the title and description were implemented as stated in the issue. The images provided in the pull request are excellent too. On the website, the title doesn't spill out of the card and the project page reflects the changes you implemented.
Could you add a brief statement explaining why the changes were made in your pull request comment (why change the title and description)? It's clear in this issue why, but this is mainly to get into the habit of good documentation practices.
Thanks for the review Jeff! |
@Adastros thanks for reviewing this PR! I updated my PR comment to include brief explanations on why changes were made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattmalane thanks for implementing the update. Looks good!
Fixes #4082
What changes did you make and why did you make them ?
Not Today
. Reason for change is to make sure that the title fits onNot Today
mini-card located on the program areas page. Before the change, the title runs off the mini-card (see visual changes below).Not Today - the self-defense against suicidal thoughts app is intended to help people wait out periods of suicidal thinking without acting on their thoughts.
Reason for change is to describe the project in a more inviting way.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied