Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the value of title and description in not-today.md #4121

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

mattmalane
Copy link
Member

@mattmalane mattmalane commented Mar 7, 2023

Fixes #4082

What changes did you make and why did you make them ?

  • Changed the value of title to Not Today. Reason for change is to make sure that the title fits on Not Today mini-card located on the program areas page. Before the change, the title runs off the mini-card (see visual changes below).
  • Changed the value of description to Not Today - the self-defense against suicidal thoughts app is intended to help people wait out periods of suicidal thinking without acting on their thoughts. Reason for change is to describe the project in a more inviting way.
  • Confirmed in local environment that the title does not run off the mini-card.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied mini-card-before description-before
Visuals after changes are applied mini-card-after description-after

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b mattmalane-update-not-today-4082 gh-pages
git pull https://github.com/mattmalane/website.git update-not-today-4082

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Program Area https://www.hackforla.org/program-areas Complexity: Good second issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 7, 2023
Copy link
Member

@jefflueck jefflueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I love that you included screenshots for me to look at.

@Adastros Adastros self-requested a review March 8, 2023 06:22
@Adastros
Copy link
Member

Adastros commented Mar 8, 2023

Availability (PST): 10:30 - 11PM 07MAR23, 9 - 11 PM 07MAR23
Review ETA (PST): 11 PM 07MAR23

Copy link
Member

@Adastros Adastros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattmalane good job on completing the issue! The changes to the title and description were implemented as stated in the issue. The images provided in the pull request are excellent too. On the website, the title doesn't spill out of the card and the project page reflects the changes you implemented.

Could you add a brief statement explaining why the changes were made in your pull request comment (why change the title and description)? It's clear in this issue why, but this is mainly to get into the habit of good documentation practices.

@mattmalane
Copy link
Member Author

Looks great. I love that you included screenshots for me to look at.

Thanks for the review Jeff!

@mattmalane
Copy link
Member Author

mattmalane commented Mar 8, 2023

@mattmalane good job on completing the issue! The changes to the title and description were implemented as stated in the issue. The images provided in the pull request are excellent too. On the website, the title doesn't spill out of the card and the project page reflects the changes you implemented.

Could you add a brief statement explaining why the changes were made in your pull request comment (why change the title and description)? It's clear in this issue why, but this is mainly to get into the habit of good documentation practices.

@Adastros thanks for reviewing this PR! I updated my PR comment to include brief explanations on why changes were made.

@mattmalane mattmalane requested a review from Adastros March 8, 2023 23:42
Copy link
Member

@Adastros Adastros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattmalane thanks for implementing the update. Looks good!

@Adastros Adastros merged commit 7dbba1e into hackforla:gh-pages Mar 9, 2023
@mattmalane mattmalane deleted the update-not-today-4082 branch March 14, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Program Area https://www.hackforla.org/program-areas role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change title and description in not-today.md
4 participants