Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dependabot file 3843 #4080

Conversation

kurikurichan
Copy link
Member

Fixes #3843

What changes did you make and why did you make them ?

  • I created a dependencies.yml file, following the instructions for Github Actions that GH provided
  • I added instructions for NPM, Docker, & GH Actions
  • I have not tested this, it needs to be tested with an outdated dependency

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Note: There was no dependabot.yml file

Visuals after changes are applied

Screen Shot 2023-03-01 at 11 42 28 AM

image

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b kurikurichan-create-dependabot-file-3843 gh-pages
git pull https://github.com/kurikurichan/website.git create-dependabot-file-3843

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: dev leads Tasks for technical leads labels Mar 1, 2023
@kurikurichan
Copy link
Member Author

After making this pull request, I made 1 more change to this branch (a critical change, it was in the wrong file location which was causing its deployment to fail). I'm not sure if this pull request reflects that.

It should be in .github and not .github/workflows

@d-perez-8 d-perez-8 self-requested a review March 2, 2023 01:53
@d-perez-8
Copy link
Member

Availability: 3-6pm
ETA: 3/2/2023

@d-perez-8
Copy link
Member

Hi @kurikurichan, thank you for doing this issue. Just had a question to better understand this issue. How did you know to add npm, docker, and github-actions to the package-ecosystems?

@roslynwythe roslynwythe requested review from roslynwythe and removed request for roslynwythe March 2, 2023 04:54
@roslynwythe
Copy link
Member

roslynwythe commented Mar 2, 2023

@kurikurichan Thank you for working on this issue. The file changed by this PR is at .github/workflows/dependabot.yml, and from your comment above it sounds like that is not the correct path. In that case, please push another commit, after staging and committing the file deletion and addition.

Also please edit the PR to remove the "Visuals before" and "Visuals after" sections. If there are no visual changes to the website, we advise to delete the details and summary tags and replace them with an explanation for no images like:

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website

@kurikurichan
Copy link
Member Author

Hi Daniel, if there are more package ecosystems, please let me know. The documentation says to at least do github actions, and I noticed that we have package.json and docker files, so I added those too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers role: dev leads Tasks for technical leads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dependabot.yml file for dependabot to create pull requests
3 participants