Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Sort Function for Project Meeting Times #4052

Merged

Conversation

bootcamp-brian
Copy link
Member

Fixes #4028

What changes did you make and why did you make them ?

  • Created a sortByDate( ) helper function to sort the VRMS data's array of objects by their "date" and "startTime" keys
  • Called sortByDate( ) in appendMeetingTimes( ) to sort VRMS data before looping through it
  • Verified changes to /projects/food-oasis page in local environment

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

projects-food-oasis-before

Visuals after changes are applied

projects-food-oasis-after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b bootcamp-brian-create-sort-function-4028 gh-pages
git pull https://github.com/bootcamp-brian/website.git create-sort-function-4028

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe P-Feature: Projects page https://www.hackforla.org/projects/ size: 1pt Can be done in 4-6 hours labels Feb 26, 2023
@t-will-gillis t-will-gillis self-requested a review February 26, 2023 23:08
@t-will-gillis
Copy link
Member

availability: Sun 26 Feb
eta: 9 pm

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bootcamp-brian Awesome job! JavaScript is not my strength but I can see that the code looks clean, it is easy to read and understand, and you have added comments / explanations. I also notice that you have chosen ‘Monday’ to be the first day of the week. My opinion is that this is perfect - this is the order I like to see the meeting times presented (instead of ‘Sunday’ first).
I checked the project cards in Docker and it appears all days and times are being sorted as intended and there are no unexpected results.

Great job again!

@bootcamp-brian
Copy link
Member Author

Hey @bootcamp-brian Awesome job! JavaScript is not my strength but I can see that the code looks clean, it is easy to read and understand, and you have added comments / explanations. I also notice that you have chosen ‘Monday’ to be the first day of the week. My opinion is that this is perfect - this is the order I like to see the meeting times presented (instead of ‘Sunday’ first). I checked the project cards in Docker and it appears all days and times are being sorted as intended and there are no unexpected results.

Great job again!

Thanks for the feedback!

@bootcamp-brian bootcamp-brian deleted the create-sort-function-4028 branch February 27, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Create a Function To Sort Project Meeting Times
2 participants