Update alt text wcag 3875 #3962
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
Review ETA: 6 PM PT 02/11/2023 Sat |
|
Review ETA: EOD 2/13 |
There was a problem hiding this comment.
@mademarc Thank you for working on this issue and I see that you were able to remove the alt text as requested in the issue! However, the format of the page was changed in your PR. Please ensure that the rest of the code isn't changed to keep the code readable and clean. i.e. the only change in the file should be on line 24 from the original code with the alt tag.
|
Hey @RyanGehris No problem as i am glad to contribute for this great organization :) |
blulady
removed
the
2 weeks inactive
|
@mademarc I am glad you enjoy contributing to HackForLA so much! It looks like Jaret requested changes to your pull request. If you have any questions, I recommend reaching out to him directly. Once your changes are made, please let myself and Jaret know. I'd be happy to review it again. |
|
hey @RyanGehris Thanks for the feedback and will reach out to @Jaretzbalba on this matter :) |
|
@Jaretzbalba @RyanGehris Hey everyone, I worked with @mademarc on this. Seems like we can't kink out the extra spaces so we may just accept it the way it is. We were able to fix the formatting, theres just a few extra spaces we can't seem to get rid of. Please review the changes once more and test in docker to ensure site runs smoothly. Thanks for all your help! |
There was a problem hiding this comment.
The site runs smoothly, and after adding the necessary code changes to comply with WCAG the webpage formatting is unaffected. Great work @mademarc and thank you for helping out @plang-psm
|
Thanks @RyanGehris and respect @plang-psm for being cool/professional as well :) |
There was a problem hiding this comment.
@mademarc Thank you for making the necessary changes! Everything looks good now and great job on this first issue!
There was a problem hiding this comment.
Hey @mademarc - congrats on your first issue! In Docker the Program Areas page appears to be loading correctly with no issues. Thanks!
Fixes #3875
What changes did you make and why did you make them ?
changed the program areas from
<img class="page-card-image" src="{{ program_areas[1].image }}" alt="{{ program_areas[1].image_alt }}" />changed to
<img class="page-card-image" src="{{ program_areas[1].image }}" alt="" />As a developer, we need to provide clear and descriptive alt text on the Program Areas page so that we adhere to the Web Content Accessibility Guidelines (WCAG) and we can achieve our mission of inclusivity.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
-no visual changes were made
Visuals before changes are applied
Visuals after changes are applied