Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project meeting time not displaying on VRMS project page #3939

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

MattPereira
Copy link
Contributor

@MattPereira MattPereira commented Feb 5, 2023

Fixes #3890

What changes did you make and why did you make them ?

  • Wrapped the logic of the for loop that appends meeting times to the project page with a try...catch block so that the loop doesn't prematurely exit if an error is thrown
  • Further refactored and simplified the for loop to make it more readable and less susceptible to future errors
  • Removed all of the legacy code associated with making a fetch() request to the VRMS API since we are now handling that with a cron job that runs in vrms-data.yml
  • Added .toLowerCase() to both the projectTitle and projectName variables because a letter casing discrepancy was causing the "Access The Data" meeting times to not be displayed

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image
image

Visuals after changes are applied

image

image

…code to be more readable, and remove legacy code
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b MattPereira-project-meeting-bug-3890 gh-pages
git pull https://github.com/MattPereira/website.git project-meeting-bug-3890

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 1pt Can be done in 4-6 hours labels Feb 5, 2023
@blulady blulady self-requested a review February 6, 2023 00:21
Copy link
Member

@blulady blulady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Great job fixing the issues and cleaning up the code. The fix works as intended. Has no unintended side effects. The linked issue talks about documentation and while there is documentation in that issue, it might be nice to have it else where, however that is a debate for another day or maybe work for another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Project meeting data from VRMS is not updating
2 participants