Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the alt tag description #3923

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

KazushiR
Copy link
Member

@KazushiR KazushiR commented Feb 2, 2023

Fixes #3255

What changes did you make and why did you make them ?

  • The alt tag for Westside was labeled as "Westside L.A.
  • Changed the alt tag to show "Westside" per the standard of WCAG for issue 3255

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b KazushiR-change-alt-pages-3255 gh-pages
git pull https://github.com/KazushiR/website.git change-alt-pages-3255

@MattPereira
Copy link
Contributor

@KazushiR please be sure link the issue # associated with this pull request on the first line of your creation comment

( I have also made this mistake before lol )

Fixes #replace_this_text_with_the_issue_number

@bzzz-coding bzzz-coding self-requested a review February 2, 2023 23:53
@bzzz-coding
Copy link
Member

bzzz-coding commented Feb 2, 2023

Availability: Tuesday and Thursday evenings.
ETA: I'll update the ETA after the issue is linked in this PR.

@KazushiR KazushiR linked an issue Feb 3, 2023 that may be closed by this pull request
4 tasks
@KazushiR
Copy link
Member Author

KazushiR commented Feb 3, 2023

@KazushiR please be sure link the issue # associated with this pull request on the first line of your creation comment

( I have also made this mistake before lol )

Fixes #replace_this_text_with_the_issue_number

@bzzz-coding I believe the issue# has been linked to this PR.

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Size: Good second issue P-Feature: Events https://www.hackforla.org/events/ Feature: Accessibility Issues that would broaden website accessibility size: 0.5pt Can be done in 3 hours or less labels Feb 3, 2023
@bzzz-coding
Copy link
Member

@KazushiR Thanks for linking the issue! Here's my updated ETA:
ETA: By end of day 2/6/23

Copy link
Member

@bzzz-coding bzzz-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KazushiR Thanks for working on this issue!

I can see that you have updated the alt text from "Westside L.A." to "Westside" for the correct event card.

I also ran docker and can see the change your made comparing to the current HfLA site in Developer Tools:
HfLA site:
Screen Shot 2023-02-06 at 6 45 14 PM

After the change:
Screen Shot 2023-02-06 at 6 44 34 PM

Good job!

@jdingeman jdingeman merged commit 9ffe099 into hackforla:gh-pages Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers P-Feature: Events https://www.hackforla.org/events/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change alt text for westside location image on events page
5 participants