Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blank issue form with dependency #3809

Conversation

Adastros
Copy link
Member

Fixes #2904

What changes did you make and why did you make them ?

  • Updated the issue form to remove the dropdown question since the answer to the question is 'yes' by default. The form will only be used for issues with dependencies.
  • Added a description for the Dependency section and a tasklist value in the textarea

These updates were made to help improve the layout and use of the form.

Screenshots of Proposed Changes Of The Website

Visuals before changes are applied

Image

Visuals after changes are applied

Image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Adastros-update-blank-issue-form-with-dependency-2904 gh-pages
git pull https://github.com/Adastros/website.git update-blank-issue-form-with-dependency-2904

@github-actions github-actions bot added Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Complexity: Medium Status: Updated No blockers and update is ready for review labels Jan 11, 2023
@t-will-gillis t-will-gillis self-requested a review January 11, 2023 19:08
@t-will-gillis
Copy link
Member

Availability: 12-2 Weds 1/11
ETA: Weds 1/11

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Adastros
This looks good. I tested the form locally and it appears to be functioning as intended. I read your comments to Bonnie about using label: Dependency and description: “Add dependencies (ideally by issue #)”. Those are a great calls and improve upon what was in the original issue. Very nice.

My only other observation is that I feel that it would be cleaner if this file used either single quotes or double quotes, when quotes are used. I am still new-ish to YAML, and I see that sometimes quotes are necessary (for example, lines 9 and 10 both require quotes) and sometimes they are not (lines 16 and 17 seem to function the same with or without quotes). But since a.) it does not appear to affect the functionality and b.) the other YAML files in this directory are inconsistent as well, it may be better to leave this alone.
Good job again and thanks!

@blulady
Copy link
Member

blulady commented Jan 13, 2023

Hey @Adastros,
Awesome job. I concur with Will, we should have some standard but looking at the rest of the .yml files in the directory, it kind of already does. If you go to the other .yml files the names/descriptions/titles mostly seem to have single quotes at the top and double quotes for the rest of the labels/values/descriptions below. Looking into all of that is outside the scope of this issue, @hackforla/website-merge could consider creating an issue to look into it & then a bunch of little issues if we decide to implement the change. What I am dying to know is how you have title above the dependency area because when I switch to @Adastros's branch my issue looks slightly different.

Screenshot (338)

But that matches HackForLA's website
Screenshot (339)

So I am going to merge it but please explain!

@blulady blulady merged commit 0868255 into hackforla:gh-pages Jan 13, 2023
@Adastros
Copy link
Member Author

Those are good points @t-will-gillis and @blulady. We can def make it into issues to help standardize the .yml files.

Hi @blulady, could you clarify the difference you saw on your branch? Was the table/title that is circled in the images not appearing at the top of the form?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging this pull request may close these issues.

Update blank issue form with dependency
3 participants