-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update blank issue form with dependency #3809
Update blank issue form with dependency #3809
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability: 12-2 Weds 1/11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Adastros
This looks good. I tested the form locally and it appears to be functioning as intended. I read your comments to Bonnie about using label: Dependency
and description: “Add dependencies (ideally by issue #)”
. Those are a great calls and improve upon what was in the original issue. Very nice.
My only other observation is that I feel that it would be cleaner if this file used either single quotes or double quotes, when quotes are used. I am still new-ish to YAML, and I see that sometimes quotes are necessary (for example, lines 9 and 10 both require quotes) and sometimes they are not (lines 16 and 17 seem to function the same with or without quotes). But since a.) it does not appear to affect the functionality and b.) the other YAML files in this directory are inconsistent as well, it may be better to leave this alone.
Good job again and thanks!
Hey @Adastros, But that matches HackForLA's website So I am going to merge it but please explain! |
Those are good points @t-will-gillis and @blulady. We can def make it into issues to help standardize the Hi @blulady, could you clarify the difference you saw on your branch? Was the table/title that is circled in the images not appearing at the top of the form? |
Fixes #2904
What changes did you make and why did you make them ?
These updates were made to help improve the layout and use of the form.
Screenshots of Proposed Changes Of The Website
Visuals before changes are applied
Visuals after changes are applied