Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated UI/UX CoP card #3736

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Updated UI/UX CoP card #3736

merged 1 commit into from
Nov 24, 2022

Conversation

angelenelm
Copy link
Member

Fixes #3691

What changes did you make and why did you make them?

  • Updated _data/internal/communities/ui-ux.yml to reflect current UI/UX CoP leadership

Screenshots of proposed changes of the website (if any; please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b angelenelm-update-ui-ux-cop-card-3691 gh-pages
git pull https://github.com/angelenelm/website.git update-ui-ux-cop-card-3691

@github-actions github-actions bot added P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Complexity: Small Take this type of issues after the successful merge of your second good first issue time sensitive Needs to be worked on by a particular timeframe labels Nov 21, 2022
@Adastros Adastros self-requested a review November 22, 2022 08:10
@Adastros
Copy link
Member

Review ETA: 11PM 22NOV22
Availability: 9 - 11 PM 22NOV22

@MattPereira MattPereira requested a review from jyaymie November 23, 2022 03:15
@jyaymie
Copy link
Member

jyaymie commented Nov 23, 2022

Review ETA: 11/23/22
Availability: 11/23/22 Flexible

Adastros
Adastros approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@Adastros Adastros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @angelenelm! The UI/UX CoP leadership cards were updated with the correct information! Nice job on including clear screenshots of the changes too!

jyaymie
jyaymie reviewed Nov 23, 2022
View reviewed changes
Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @angelenelm! You even put in the effort to find the information to update the picture property for each lead! For some reason, I am not able to see the visual changes on my end, but I'm pretty sure it has to do with me and not you. I'll get some support and hopefully submit my approval as soon as poss!

@angelenelm
Copy link
Member Author

This looks great, @angelenelm! You even put in the effort to find the information to update the picture property for each lead! For some reason, I am not able to see the visual changes on my end, but I'm pretty sure it has to do with me and not you. I'll get some support and hopefully submit my approval as soon as poss!

@jyaymie Thanks for reviewing! I ran into this issue as well, I had to follow the instructions in this section of the Contributing wiki (https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#i-what-if-you-cannot-see-your-changes-locally-within-docker) to get it to work!

jyaymie
jyaymie approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are a rockstar, @angelenelm! Thank you for your help!

@blulady
Copy link
Member

blulady commented Nov 24, 2022

PR goes from the correct branch to the correct branch. Has the correct issue link that is addressed by the PR. Code changes are clean. Communities of Practice page looks good when I deploy it locally. Looks good!! And nice job grabbing the links for the GitHub avatars.

@blulady blulady merged commit 73b4300 into hackforla:gh-pages Nov 24, 2022
MattPereira pushed a commit to MattPereira/website that referenced this pull request Nov 25, 2022
@angelenelm
updated ui-ux.yml leadership per hackforla#3691 (hackforla#3736)
c48e618
@angelenelm angelenelm deleted the update-ui-ux-cop-card-3691 branch November 27, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyaymie jyaymie jyaymie approved these changes

@Adastros Adastros Adastros approved these changes

Assignees
No one assigned
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Communities of Practice information updates: UI/UX
4 participants
@angelenelm @Adastros @jyaymie @blulady