Updated content field and removed type field in internal/rocket.yml #3728
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
Review ETA: 7PM PST 11/16/2022 |
There was a problem hiding this comment.
The requested changes to rocket.yml in the issue are addressed correctly, and are done on the correct branch. Good job @wendybarrios :)
|
Review ETA: 11PM 16NOV22 |
There was a problem hiding this comment.
Good job @wendybarrios! You completed the action items successfully!
One thing I would like to note is that line 11 is empty. I don't believe this affects anything on the site but to keep it consistent with the structure of the other credit files, I think it would be best to remove the empty line.
What are your thoughts @angelenelm?
|
@Adastros I think that's a fair change to request :) |
There was a problem hiding this comment.
- Hey @wendybarrios could you remove space from line no. 11.
- Also in your comment on the top of the Pull request, I would suggest keeping it short. for e.g. 'removed type field and update content filed' in bullet points. Instead of copying the checkboxes from the original issue.
- You can look at other PR's for the format
There was a problem hiding this comment.
Thank you for making the changes. It's correct. Good job! @wendybarrios
Fixes #2873
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website
No visual changes to the website.