Update blank issue form with dependency #3717
Conversation
The blank issue form (blank-issue-form.yml) was updated to move the dependency form fields from the bottom of the form to the top of the form. In addition, the name and description of the form in the ymal file were updated to clarify what the form is for.
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
Feature: Administrative
|
Review ETA: End of Day 11/14/22 |
|
Review ETA: 11/14/22 |
There was a problem hiding this comment.
Hi Adastros- Great job! It appears that you have made the changes to blank-issue-form.yml just as asked for in issue #2904. These changes are testable and appear to function as intended with no unexpected side effects. So again looks great on your end!
I do have some questions/ comments: first whether the file name should change to blank-issue-form-with-dependency.yml , and second whether it is useful to have a dropdown asking if there is a dependency (since the answer should be 'yes' if you are using this form). HOWEVER these questions/comments were not part of the scope of this issue, so I will not 'request changes' on this issue.
|
Review ETA: 11/14/22 11:30pm |
|
Hi @t-will-gillis, I messaged @JessicaLucindaCheng about her thoughts on renaming the file yesterday. She agrees on changing the name of the file to |
There was a problem hiding this comment.
This looks great, @Adastros! I appreciated the red boxes in your screenshots that clearly indicated the visible changes to expect. @t-will-gillis made excellent points on which you were quick to take action. Awesome!
There was a problem hiding this comment.
Good work on this one @Adastros!
You flawlessly completed all of the action items from the issue, and it looks like you're doing a commendable job communicating with the issue creator about renaming the file. Great job addressing @t-will-gillis thoughtful suggestions. You might also consider changing the dependency-explanation textarea to be required if Jessica decides you should remove the dependency yes/no dropdown.
Keep up the good work! 👍
Fixes #2904
What changes did you make and why did you make them ?
The blank issue form with dependency (blank-issue-form.yml) was updated to move the dependency form fields from the bottom of the form to the top of the form. In addition, the name and description of the form in the yml file were updated to clarify what the form is for. This was performed to make it clear that the form is for issues with dependencies. This will make it easier and quicker to pick an issue template and write an issue.
Screenshots of Proposed Changes Of The Issue Form
Visuals before changes are applied
Visuals after changes are applied