Edit content field and remove type field from security.yml credits file #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
Availability: 10PM-12PM |
|
Nice work @Adastros. It's the right changes to the right file, and your branch / commit naming conventions are clean. |
luiderek
approved these changes
Nov 5, 2022
|
Review ETA: End of Day 11/6/22 |
|
Review ETA: 9 PM 6/11/2022 |
MattPereira
approved these changes
Nov 6, 2022
There was a problem hiding this comment.
Good work on this one @Adastros ! 👍
You linked the issue number properly and removed the redundant code from secuirty.yml. Keep up the good work!
|
Review ETA: 11/7/22 7:30am |
jyaymie
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2858
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Updating fields in credits file. No visual changes to the website.