making program-areas project cards point towards respective project links #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
P-Feature: Program Area
|
Review ETA: End of Day 11/3/22 |
MattPereira
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Great work on this one @luiderek ! 👍
The variable name project_relative_path is superbly descriptive and your project.slug solution grabs the projects filename, replace spaces with dashes, and strips the .md from the end of the filename. All of the program areas page's project-card-mini-title's href attributes are now set to the correct location! 🎉
|
ETA: EOD 11/4 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3592
What changes did you make and why did you make them ?
project_relative_pathwhich was set as the filename of the project using Jekyll's .slug attribute, using a filter to prepend it by "../projects/".<a>element's href property of the<li class='project-card-mini'>element with the new variable.Screenshots of Proposed Changes Of The Website - No visual changes.
Took a little bit to get more familiar with the overall website structure / Jekyll, but I think this oughta address the issue.