Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused alt-hero field from shared housing project file #3676

Closed
wants to merge 3 commits into from

Conversation

ldaws003
Copy link
Member

Fixes #3210

What changes did you make and why did you make them ?

  • removed line 8: "alt-hero: 'Light-gray background'" from the file _projects/shared-housing-project.md due to it being unused

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No screenshots, since the alt text wasn't used.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ldaws003-gh-pages gh-pages
git pull https://github.com/ldaws003/website.git gh-pages

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Oct 30, 2022
@giroz giroz self-requested a review October 30, 2022 17:18
@giroz
Copy link
Member

giroz commented Oct 30, 2022

ETA: 10-31-22
Availability: 2 hours

@gstemmann gstemmann self-requested a review October 30, 2022 17:47
@gstemmann
Copy link
Member

ETA: 10-31-22
Availability: 6 hours

Copy link
Member

@gstemmann gstemmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you appropriately removed the line 8 for the alt hero that was requested.
Awesome Job!

Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ldaws003 I see that you haven't created a topic branch. Please follow the guide.
For each issue create a topic branch and then create a pull request to merge the changes.

  • You may close the PR and create new.

donotpushchangestoghpagescreateanewbranch

Copy link
Member

@giroz giroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey ldaws003. I see you haven't put this in your own branch.
ldaws003 wants to merge 3 commits into hackforla:gh-pages from ldaws003:gh-pages
I don't know if your changes would effect hackforla: gh-pages or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging this pull request may close these issues.

Remove unused alt-hero field from shared-housing-project.md project file
5 participants