Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused 'alt-hero' field, line 8, from lucky-parking.md #3642

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Removed unused 'alt-hero' field, line 8, from lucky-parking.md #3642

merged 1 commit into from
Oct 20, 2022

Conversation

t-will-gillis
Copy link
Member

Fixes #3204

What changes did you make and why did you make them ?

  • Deleted unused alt-hero text, originally on line 8 of the lucky-parking.md file.
  • This was done to reduce website loading time, and to make the code easier to understand and review.

Screenshots of Proposed Changes Of The Website

n/a- The alt text was never used.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-remove-alt-hero-lucky-pkg-3204 gh-pages
git pull https://github.com/t-will-gillis/website.git remove-alt-hero-lucky-pkg-3204

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Oct 19, 2022
@MattPereira MattPereira self-requested a review October 19, 2022 18:48
@MattPereira
Copy link
Contributor

Review ETA: 12:30 PM 10/19/22
Availability: 12-4 PM Wednesday

MattPereira
MattPereira approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@MattPereira MattPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Will! You removed line 8 to perfection!

One minor note: it looks like this pull request has not yet been added to the project board

@jyaymie jyaymie self-requested a review October 19, 2022 21:08
@jyaymie
Copy link
Member

jyaymie commented Oct 19, 2022

Review ETA: 2:30pm PST 10/19/22
Availability: 2 to 2:30pm PST 10/19/22

jyaymie
jyaymie approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@jyaymie jyaymie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! I appreciated that you specified the affected line of code.

@jdingeman jdingeman merged commit 4afd998 into hackforla:gh-pages Oct 20, 2022
@t-will-gillis t-will-gillis deleted the remove-alt-hero-lucky-pkg-3204 branch October 20, 2022 02:35
@kathrynsilvaconway kathrynsilvaconway mentioned this pull request Oct 26, 2022
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyaymie jyaymie jyaymie approved these changes

@MattPereira MattPereira MattPereira approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused alt-hero field from lucky-parking.md project file
5 participants
@t-will-gillis @MattPereira @jyaymie @ExperimentsInHonesty @jdingeman