Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused alt-hero field from hellogov.md project file #3624

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Remove unused alt-hero field from hellogov.md project file #3624

merged 1 commit into from
Oct 15, 2022

Conversation

jyaymie
Copy link
Member

@jyaymie jyaymie commented Oct 14, 2022

Fixes #3201

What changes did you make and why did you make them ?

  • Removed the alt-hero field because it's not being used in the codebase

Screenshots of Proposed Changes Of The Website

The removed text was unused, so there are no visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jyaymie-remove-alt-hero-field-3201 gh-pages
git pull https://github.com/jyaymie/website.git remove-alt-hero-field-3201

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Oct 14, 2022
@gstemmann
Copy link
Member

Review ETA: 10 pm Oct 20, 2022
Availability: 6 Hours

@gstemmann gstemmann self-requested a review October 15, 2022 21:38
gstemmann
gstemmann approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@gstemmann gstemmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you successfully removed the alt-hero line. And the branch was properly push. to the correct repository, Great work.

@jdingeman jdingeman merged commit 8d14920 into hackforla:gh-pages Oct 15, 2022
t-will-gillis added a commit to t-will-gillis/website that referenced this pull request Oct 16, 2022
@t-will-gillis
Merge pull request #1 from hackforla/gh-pages
bac1104 
 Remove unused alt-hero field (hackforla#3624)
@arpitapandya arpitapandya mentioned this pull request Oct 16, 2022
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gstemmann gstemmann gstemmann approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused alt-hero field from hellogov.md project file
4 participants
@jyaymie @gstemmann @ExperimentsInHonesty @jdingeman