Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created blank issue form with no dependency #3589

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Created blank issue form with no dependency #3589

merged 1 commit into from
Sep 30, 2022

Conversation

carolemlago
Copy link
Member

@carolemlago carolemlago commented Sep 29, 2022 •
edited
Loading

Fixes #2954

What changes did you make and why did you make them ?

  • Reviewed blank issue form yml file and blank issue form.
  • Created a blank issue form with no dependencies by copying from previous file.
  • Modified lines 1 and 2, and deleted lines 26-38.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Screen Shot 2022-09-28 at 5 05 35 PM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b carolemlago-create-blank-issue-2954 gh-pages
git pull https://github.com/carolemlago/website.git create-blank-issue-2954

@github-actions github-actions bot added Feature: Accessibility Issues that would broaden website accessibility P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Sep 29, 2022
@jdingeman jdingeman self-requested a review September 29, 2022 01:03
@jdingeman
Copy link
Member

ETA: EOD 9/28/2022
Availability: 4hrs

@jdingeman
Copy link
Member

Hi @carolemlago, can you please verify you've linked the correct issue? #3098 Change alt text for card image in open community survey md file

jdingeman
jdingeman approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@jdingeman jdingeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Double checked the synatx with YAMLint and it came out clean. Nice job!

@carolemlago
Copy link
Member Author

#3589

Hi @carolemlago, can you please verify you've linked the correct issue? #3098 Change alt text for card image in open community survey md file

Just fixed. Thank you @jdingeman

kathrynsilvaconway
kathrynsilvaconway previously requested changes Sep 30, 2022
View reviewed changes
Copy link
Member

@kathrynsilvaconway kathrynsilvaconway left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carolemlago Nice work. Everything looks clean. This PR seems to be linked to itself. At the top of the page, please change the link to the number for the issue, not the PR. Be sure to request a re-review after you make this change and I will approve it.

@github-actions github-actions bot added Feature: Administrative Administrative chores etc. Complexity: Small Take this type of issues after the successful merge of your second good first issue Status: Updated No blockers and update is ready for review and removed role: back end/devOps Tasks for back-end developers Size: Good second issue Feature: Accessibility Issues that would broaden website accessibility P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement labels Sep 30, 2022
@arpitapandya
Copy link
Member

ETA: EOD 2022-09-30
Availability: 20 minutes

arpitapandya
arpitapandya approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making all the changes and adding a link to the issue. Great job! @carolemlago

@arpitapandya arpitapandya dismissed kathrynsilvaconway’s stale review September 30, 2022 21:52

Issue addressed and discussed with Carole

@arpitapandya arpitapandya merged commit 47c4186 into hackforla:gh-pages Sep 30, 2022
@carolemlago carolemlago deleted the create-blank-issue-2954 branch September 30, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdingeman jdingeman jdingeman approved these changes

@arpitapandya arpitapandya arpitapandya approved these changes

@kathrynsilvaconway kathrynsilvaconway Awaiting requested review from kathrynsilvaconway

Assignees
No one assigned
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a blank issue form with no dependency
4 participants
@carolemlago @jdingeman @arpitapandya @kathrynsilvaconway