Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Styling of Header of Projects 'Info Pages'. #3582

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Fix Styling of Header of Projects 'Info Pages'. #3582

merged 1 commit into from
Sep 28, 2022

Conversation

GRISONRF
Copy link
Member

@GRISONRF GRISONRF commented Sep 26, 2022 •
edited
Loading

Fixes #3377

What changes did you make and why did you make them ?

  • Added styling components in lines 387 to 411.
  • File path: _sass/components/_project-page.scss

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

Capture

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b GRISONRF-fix-styling-of-header-3377 feature-homepage-launch
git pull https://github.com/GRISONRF/website.git fix-styling-of-header-3377

@github-actions github-actions bot added Bug Something isn't working Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Sep 26, 2022
@tunglinn tunglinn self-requested a review September 26, 2022 20:57
@tunglinn
Copy link
Member

ETA: by end of 9/27
Availability: 1hr

@arpitapandya arpitapandya self-requested a review September 27, 2022 16:11
@arpitapandya
Copy link
Member

ETA: EOD 2022-09-27
Availability: 1hr

arpitapandya
arpitapandya approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are correct and visible. It doesn't break anything in the mobile, desktop, and tablet views. Great job!! @GRISONRF

tunglinn
tunglinn approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@tunglinn tunglinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge branches are correct. Changes follow linked issue. Site does not break and visual changes are seen. Good work!

@arpitapandya arpitapandya merged commit 3aacc2b into hackforla:feature-homepage-launch Sep 28, 2022
@ExperimentsInHonesty ExperimentsInHonesty mentioned this pull request Oct 2, 2022
Open
2 tasks
@GRISONRF GRISONRF deleted the fix-styling-of-header-3377 branch October 4, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunglinn tunglinn tunglinn approved these changes

@arpitapandya arpitapandya arpitapandya approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GRISONRF @tunglinn @arpitapandya