Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Alt Text For Sdg Image #3577

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Change Alt Text For Sdg Image #3577

merged 1 commit into from
Sep 24, 2022

Conversation

GRISONRF
Copy link
Member

Fixes #3099

What changes did you make and why did you make them ?

  • Changed line 79 because it was inaccurate and not descriptive.
  • Changed it to: '16: peace, justice and strong institutions'

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b GRISONRF-change-alt-text-3099 gh-pages
git pull https://github.com/GRISONRF/website.git change-alt-text-3099

@github-actions github-actions bot added Feature: Accessibility Issues that would broaden website accessibility P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Sep 23, 2022
@lilyarj lilyarj self-requested a review September 23, 2022 22:38
@lilyarj
Copy link
Member

lilyarj commented Sep 23, 2022

Eta: 9/23/22
Availability: 2hrs

lilyarj
lilyarj approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@lilyarj lilyarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@Unity7 Unity7 self-requested a review September 24, 2022 00:31
Unity7
Unity7 reviewed Sep 24, 2022
View reviewed changes
Copy link
Member

@Unity7 Unity7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I was able to identify the changes you made to the alt text.

@arpitapandya arpitapandya self-requested a review September 24, 2022 00:40
@arpitapandya
Copy link
Member

ETA: EOD 2022-09-23
Availability: 30 minutes

arpitapandya
arpitapandya approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are correct and doesn't break anything. Great job!! @GRISONRF

@arpitapandya arpitapandya merged commit 4a5bb2f into hackforla:gh-pages Sep 24, 2022
@arpitapandya arpitapandya mentioned this pull request Sep 25, 2022
Open
17 tasks
@GRISONRF GRISONRF deleted the change-alt-text-3099 branch September 26, 2022 15:53
@kathrynsilvaconway kathrynsilvaconway mentioned this pull request Sep 28, 2022
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unity7 Unity7 Unity7 left review comments

@lilyarj lilyarj lilyarj approved these changes

@arpitapandya arpitapandya arpitapandya approved these changes

Assignees
No one assigned
Labels
Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change alt text for sdg image in open community survey md file
5 participants
@GRISONRF @lilyarj @arpitapandya @Unity7 @ExperimentsInHonesty