Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Alt Text on Citizen Engagement Page #3514

Conversation

attali-david
Copy link
Member

Fixes #3101

What changes did you make and why did you make them ?

  • Changed line 50 of alt text to "Lost Angeles Department of Neighborhood Empowerment"

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied No visual changes to webstie. Visuals after changes are applied

image

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b attali-david-citizen-engagement-accessibility-3101 gh-pages
git pull https://github.com/attali-david/website.git citizen-engagement-accessibility-3101

@github-actions github-actions bot added Feature: Accessibility Issues that would broaden website accessibility P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Sep 1, 2022
@jdingeman jdingeman self-requested a review September 1, 2022 19:32
@jdingeman
Copy link
Member

Availablility: Today after 3pm
ETA: EOD 9/1/2022

@arpitapandya arpitapandya self-requested a review September 1, 2022 21:07
@arpitapandya
Copy link
Member

Availability: 6 Hours
ETA: EOD 2022-09-01

Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are correct and doesn't break anything! Great job!! @attali-david

@lilyarj lilyarj self-requested a review September 2, 2022 00:48
@lilyarj
Copy link
Member

lilyarj commented Sep 2, 2022

ETA: 9/1
Availability: 2hrs

Copy link
Member

@jdingeman jdingeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nothing broken on site or in code.

Copy link
Member

@lilyarj lilyarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, site does not break!

@arpitapandya arpitapandya merged commit 8fc30f9 into hackforla:gh-pages Sep 2, 2022
@attali-david attali-david deleted the citizen-engagement-accessibility-3101 branch September 2, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging this pull request may close these issues.

Change alt text for LA neighborhood councils image in citizen engagement html file
5 participants