Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diversity.yml #3513

Merged

Conversation

attali-david
Copy link
Member

Fixes #2822

What changes did you make and why did you make them ?

  • Replaced "content" key with "content-type"
  • Replaced "Image" value of "content-type" with "image"
  • Deleted "type" key-value

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Changed yml file. No visual changes.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b attali-david-edit-diversity.yml-2822 gh-pages
git pull https://github.com/attali-david/website.git edit-diversity.yml-2822

@attali-david attali-david changed the title Edited diversity.yml file to remove redundant code. Update diversity.yml Aug 31, 2022
@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Aug 31, 2022
@arpitapandya
Copy link
Member

Availability: 6 Hours
ETA: EOD 2022-08-31

@arpitapandya arpitapandya self-requested a review August 31, 2022 23:23
Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are correct and doesn't break anything! Great job!! @attali-david

@lilyarj lilyarj self-requested a review August 31, 2022 23:41
@lilyarj
Copy link
Member

lilyarj commented Aug 31, 2022

ETA: 8/31
Availability: 2hrs

Copy link
Member

@lilyarj lilyarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great!

@arpitapandya arpitapandya merged commit 8247045 into hackforla:gh-pages Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from diversity.yml credits file
3 participants