Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects page copy with only technology and language filters #3452

Merged

Conversation

Wny-Duong
Copy link
Member

Fixes #2502

What changes did you make and why did you make them ?

  • Created a copy of the projects page that is accessible through a /projects-check/ permalink and is only accessible through permalink. It can't be reached simply by pressing the project button, only through http://localhost:4000/projects-check/ when checking locally.
  • On projects-check, there are only two filters, technologies and languages. They follow the same behavior as the default projects page filters.
    • Example 1: Selecting multiple technologies in only the technologies filter will increase the number of projects returned, as cards containing any of the selected technologies are shown.
    • Example 2: Selecting a technology filter and a language filter will restrict the number of projects returned, as it checks only for projects that contain both the specific technology and language.
    • The separated technologies and languages filter contain the same filter items as the combined technologies/languages filter used in the default projects page.
  • Note: The new files added were based off of the current-projects.html, current-projects.js, and projects-page.html files used to generate the current projects page. The html files are identical with changes to the file names referenced to ensure a separate working projects-check page. The projects page is still accessible through /projects/ and uses the old filters currently used (program areas, languages/tech, status).

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Wny-Duong-projects-check-page-2502 gh-pages
git pull https://github.com/Wny-Duong/website.git projects-check-page-2502

@github-actions github-actions bot added P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours Complexity: Large labels Aug 7, 2022
@Wny-Duong Wny-Duong changed the title Projects check page 2502 Projects page copy with only technology and language filters Aug 7, 2022
@kathrynsilvaconway
Copy link
Member

ETA: End of Day on 8/15
Availability: 4 hours

@arpitapandya
Copy link
Member

Availability: 6 Hours
ETA: EOD 2022-08-11

@Zak234 Zak234 self-requested a review August 13, 2022 20:19
@Zak234
Copy link
Contributor

Zak234 commented Aug 13, 2022

ETA: Aug. 14

Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes looks correct and visible!! Great job! @Wny-Duong

Copy link
Contributor

@Zak234 Zak234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be wrong but it looks like there are 65 combined languages and technologies in the new page and only 62 in the old page.

@Wny-Duong
Copy link
Member Author

I may be wrong but it looks like there are 65 combined languages and technologies in the new page and only 62 in the old page.

I looked into this and you're right, there are 3 more languages that were added because of my changes:
Makefile
Ruby
Svelte

These languages do show up in the project cards for the old projects page, but aren't included in the original combined languages and technologies filter. I'm not too sure why this is and I don't know if this is something that should be fixed since it technically corrects the problem of those languages not showing up in the filter in the first place.

@Zak234
Copy link
Contributor

Zak234 commented Aug 17, 2022

We could probably bring it up during office hours tomorrow

@Wny-Duong
Copy link
Member Author

Sounds good to me. I'll see you there.

@Wny-Duong
Copy link
Member Author

@Zak234 From the office hours, it looks like the new languages are fine, but there might be a need to make a new issue addressing the fact that the old Projects filters were missing the Makefile, Ruby, and Svelte language filter options since those languages are listed in some of the project cards currently existing on the Projects page.

Just leaving a note here that the changes made found three new languages that weren't previously included under the Projects page Languages/Technologies filter along with some images in case a new issue needs to be created.

Image from the projects-check language filter:
image

Images from the old projects filter:
image

Project cards using Ruby, Svelte, and Makefile on the old projects page included:
Spare
Write for All
Work for LA
BallotNav

@blulady blulady self-requested a review August 25, 2022 14:57
Copy link
Member

@blulady blulady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I made an issue requesting documentation for this.

@blulady blulady requested a review from Zak234 August 25, 2022 19:23
@kathrynsilvaconway
Copy link
Member

Here is the issue @blulady created to request documentation:
#3487

Copy link
Member

@kathrynsilvaconway kathrynsilvaconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wny-Duong Great work on this issue. The filters on the new page function as expecteda dn everything looks good. We will have to decide what to do about the items that are missing from the current project filters in a separate issue.

@kathrynsilvaconway kathrynsilvaconway merged commit 4b4e0c4 into hackforla:gh-pages Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large P-Feature: Projects page https://www.hackforla.org/projects/ role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours
Projects
Development

Successfully merging this pull request may close these issues.

Create a copy of the project page with only two filters: technology and language
5 participants