-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projects page copy with only technology and language filters #3452
Projects page copy with only technology and language filters #3452
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: End of Day on 8/15 |
Availability: 6 Hours |
ETA: Aug. 14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes looks correct and visible!! Great job! @Wny-Duong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be wrong but it looks like there are 65 combined languages and technologies in the new page and only 62 in the old page.
I looked into this and you're right, there are 3 more languages that were added because of my changes: These languages do show up in the project cards for the old projects page, but aren't included in the original combined languages and technologies filter. I'm not too sure why this is and I don't know if this is something that should be fixed since it technically corrects the problem of those languages not showing up in the filter in the first place. |
We could probably bring it up during office hours tomorrow |
Sounds good to me. I'll see you there. |
@Zak234 From the office hours, it looks like the new languages are fine, but there might be a need to make a new issue addressing the fact that the old Projects filters were missing the Makefile, Ruby, and Svelte language filter options since those languages are listed in some of the project cards currently existing on the Projects page. Just leaving a note here that the changes made found three new languages that weren't previously included under the Projects page Languages/Technologies filter along with some images in case a new issue needs to be created. Image from the projects-check language filter: Images from the old projects filter: Project cards using Ruby, Svelte, and Makefile on the old projects page included: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I made an issue requesting documentation for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wny-Duong Great work on this issue. The filters on the new page function as expecteda dn everything looks good. We will have to decide what to do about the items that are missing from the current project filters in a separate issue.
Fixes #2502
What changes did you make and why did you make them ?
/projects-check/
permalink and is only accessible through permalink. It can't be reached simply by pressing the project button, only through http://localhost:4000/projects-check/ when checking locally./projects/
and uses the old filters currently used (program areas, languages/tech, status).Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied