Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced content with content-type:image, removed type:icon in design… #3445

Conversation

CalvinTan607
Copy link
Contributor

….yml

Fixes #2818

What changes did you make and why did you make them ?

-On line 4 I replaced content: icon with content-type: image
-removed line 11 (type:icon)

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b CalvinTan607-edit-content-field-in-design.yml-2818 gh-pages
git pull https://github.com/CalvinTan607/website.git edit-content-field-in-design.yml-2818

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Aug 1, 2022
@Zak234 Zak234 self-requested a review August 1, 2022 06:01
@Zak234
Copy link
Contributor

Zak234 commented Aug 1, 2022

ETA: August 1st
Availability; Anytime

Copy link
Contributor

@Zak234 Zak234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and seems to work. Great job!

@Zak234 Zak234 merged commit b08864b into hackforla:gh-pages Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from design.yml credits file
2 participants