Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sdg image alt to comply with WCAG #3425

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

neevliberman
Copy link
Member

@neevliberman neevliberman commented Jul 24, 2022

Fixes #3095

What changes did you make and why did you make them?

  • Changed contents of the sdg-image-alt attribute to reduce wordiness

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b neevliberman-change-sdg-image-alt-3095 gh-pages
git pull https://github.com/neevliberman/website.git change-sdg-image-alt-3095

@arpitapandya arpitapandya self-requested a review July 24, 2022 23:29
@arpitapandya
Copy link
Member

Availability: 6 Hours
ETA: EOD 2022-07-25

@Zak234 Zak234 self-requested a review July 25, 2022 01:49
Copy link
Contributor

@Zak234 Zak234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great job!

@lilyarj lilyarj self-requested a review July 25, 2022 15:13
@lilyarj
Copy link
Member

lilyarj commented Jul 25, 2022

Availability: 3hrs
ETA: 7-25

Copy link
Member

@lilyarj lilyarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

Copy link
Member

@arpitapandya arpitapandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good! Great job!! @neevliberman

Copy link
Member

@blulady blulady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch being pushed is the correct branch neevliberman:change-sdg-image-alt-3095 and is going to the correct branch hackforla:gh-pages. It has a linked issue that is being properly addressed by changing line 73 in the _projects/engage.md file to '16: peace, justice and strong institutions'.
Good Job!!!

@blulady blulady merged commit 1bca6d0 into hackforla:gh-pages Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Change alt text for sdg image in engage md file
5 participants