Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit content field and remove type field from schedule.yml credits file #3369

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Edit content field and remove type field from schedule.yml credits file #3369

merged 2 commits into from
Jul 14, 2022

Conversation

seantokuzo
Copy link
Member

Fixes #2875

What changes did you make and why did you make them ?

  • In the file: website/_data/internal/credits/schedule.yml
  • Changed the 'content' field to 'content-type'
  • Removed the 'type' field
  • Changes were made following instruction from issue - reduce redundancy with these fields

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b seantokuzo-edit-yml-fields-2875 gh-pages
git pull https://github.com/seantokuzo/hack4la-website.git edit-yml-fields-2875

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Jul 14, 2022
@Wny-Duong Wny-Duong self-requested a review July 14, 2022 05:05
@Wny-Duong
Copy link
Member

Availability: 2 hours
ETA: 7/14/22

Wny-Duong
Wny-Duong suggested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@Wny-Duong Wny-Duong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to tweak line 4. From the original issue, you're meant to change it to:

content-type: image

But your change made it:

content-type: icon

@seantokuzo
Copy link
Member Author

Ah shoots I missed that. Should be updated now.

@lilyarj lilyarj requested review from lilyarj July 14, 2022 18:01
Wny-Duong
Wny-Duong approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@Wny-Duong Wny-Duong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change. Looks good!

@Wny-Duong Wny-Duong merged commit e611046 into hackforla:gh-pages Jul 14, 2022
@kathrynsilvaconway kathrynsilvaconway mentioned this pull request Jul 18, 2022
Open
12 tasks
@seantokuzo seantokuzo deleted the edit-yml-fields-2875 branch August 9, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wny-Duong Wny-Duong Wny-Duong approved these changes

@lilyarj lilyarj Awaiting requested review from lilyarj

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from schedule.yml credits file
2 participants
@seantokuzo @Wny-Duong