Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed from Content to Content-Type #3293

Closed
wants to merge 1 commit into from

Conversation

clayton1111
Copy link
Member

Fixes #2775

What changes did you make and why did you make them ?

  • changed line 4: content ----> content - type
  • removed line 11: type
  • purpose: combine 2 lines to simplify code

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No screenshot, does not change website visuals

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b clayton1111-gh-pages gh-pages
git pull https://github.com/clayton1111/website.git gh-pages

@clayton1111 clayton1111 added the good first issue Good for newcomers label Jun 23, 2022
@github-actions github-actions bot added Collaborative Work Dependency An issue is blocking the completion or starting of another issue epic P-Feature: Credit https://www.hackforla.org/credits/ role: front end Tasks for front end developers size: 2pt Can be done in 7-12 hours Complexity: Small Take this type of issues after the successful merge of your second good first issue Status: Updated No blockers and update is ready for review and removed good first issue Good for newcomers labels Jun 23, 2022
@clayton1111 clayton1111 added role: back end/devOps Tasks for back-end developers good first issue Good for newcomers size: 0.5pt Can be done in 3 hours or less and removed Collaborative Work Status: Updated No blockers and update is ready for review Dependency An issue is blocking the completion or starting of another issue Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 2pt Can be done in 7-12 hours epic labels Jun 23, 2022
@blulady blulady self-requested a review June 23, 2022 20:12
Copy link
Member

@blulady blulady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branches aren't 100%, going from clayton1111:gh-pages, this should be a feature branch in your local called something like edit-content-field-2811. The linked issue is incorrect and will need to be changed from 2775 to #2811. But the changes themselves look great. Line 4 has been corrected from content: image to content-type: image and you have successfully deleted line 11.

@clayton1111
Copy link
Member Author

Thank you for the review! I realized I had used the wrong branch number the entire time. I am unsure how to retroactively change the branch that the issue is linked to, so I went ahead and just made an entire new pull request that should be correct. This pull request can be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from yml credit files
3 participants