Update center.yml

[trz832]

Fixes #2805

What changes did you make and why did you make them ?

• Changed line 4 'content: icon' to 'content-type: image'
• Removed 'type: icon' from line 11

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b hackforla-troywzhu-patch-3 gh-pages
git pull https://github.com/hackforla/website.git troywzhu-patch-3

[Olanrewaju-Ak]

Review ETA: 7 PM 6/20/22
Availability: 2 hrs Monday

[tamara-snyder]

Availability: 1 hour
Review ETA: Jun 19, 2022

[tamara-snyder]

Hi @troywzhu, great work! I can see that you changed content: icon to content-type: image and removed the unnecessary line of code. Thank you!

[mmogri]

Availability: 1 hour
Review ETA: Jun 19, 2022

[mmogri]

It looks like the pull request has not been done from the correct branch.

From https://github.com/hackforla/website/wiki/How-to-Review-Pull-Requests:
"The commit from must be from the collaborator who opened the pulled request"
As such, the commit should be from "troywzhu:troywzhu-patch-3" (ie, from troywzhu's own account rather than a branch within hackforla).

Instead it looks like both the to and from branches are within hackforla: "troywzhu wants to merge 1 commit into gh-pages from troywzhu-patch-3"

The "from" branch should be from troywzhu's own account. Please redo the pull request with the correct branch.

[Olanrewaju-Ak]

@troywzhu good work!!. I see that you changed content: icon to content-type: image and removed the unnecessary line of code.
However, you didn't seem to follow the correct branch naming convention for your issue
Note:
You are to choose a branch name that:
-relates to the issue (No spaces!)
-includes the issue number
-The format should be such that, the words are a brief description of the issue that will make sense at a glance to someone unfamiliar with the issue.
as opposed to using troywzhu-patch-3.

I hope you can make this correction in your subsequent issues.

Inaccurate

[KBWells77]

@troywzhu Good job, you condensed the code so that it now says content-type:image. Like other reviewers said, you did not follow the Branch Naming Procedure, so the branch name is not clear. You need to follow the correct branch to and from naming procedure, as others have listed above.

[kathrynsilvaconway]

While the comments above are correct, I don't think it is possible to change the branch name. I am going to merge this request because the work is done correctly, and the author does not appear to be active with Hfla at the moment.

@troywzhu For your reference, a better branch name would be something like:

edit-content-and-type-fields-on-center-yml-2805

See: Section 2.7.b of Contributing.md