-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit content field and remove type field from board.yml, credit files #3171
Edit content field and remove type field from board.yml, credit files #3171
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: End of the day on 5/23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Comment removed
ETA: End of the day on 5/23 |
@kathrynsilvaconway This actually looks to be correct. The issues are very similar due to them being "good first issues". The issue for PR #3168 you mentioned above is for issue #2797 which changes the building.yml file. This PR affects the board.yml file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Olanrewaju-Ak Great job working on this good first issue! I see you were able to change line 4 to "content-type" and remove line 11.
Aha! Nice catch, as always, @Jaretzbalba. My mistake. I'm going to delete my first review and just write a another one with approval to avoid confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Olanrewaju-Ak Congrats on completing your first issue with Hack for LA. I see that you have changed the content field in line 4 to read 'content-type: image' and you have deleted line 11 from the board yml file. Nice work.
Fixes #2794
What changes did you make and why did you make them ?
-changed content to content-type on line 4
-Removed line 11 for the type field
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Edited text fields. No visual changes to the website.