Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit content field and remove type field from board.yml, credit files #3171

Merged

Conversation

Olanrewaju-Ak
Copy link
Member

Fixes #2794

What changes did you make and why did you make them ?

-changed content to content-type on line 4
-Removed line 11 for the type field

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Edited text fields. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Olanrewaju-Ak-edit-contentfield-2794 gh-pages
git pull https://github.com/Olanrewaju-Ak/website.git edit-contentfield-2794

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels May 23, 2022
@kathrynsilvaconway kathrynsilvaconway self-requested a review May 24, 2022 00:51
@kathrynsilvaconway
Copy link
Member

ETA: End of the day on 5/23
Availability: 1 hour

Copy link
Member

@kathrynsilvaconway kathrynsilvaconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Comment removed

@Jaretzbalba Jaretzbalba self-requested a review May 24, 2022 02:14
@Jaretzbalba
Copy link
Member

ETA: End of the day on 5/23
Availability: 1 hour

@Jaretzbalba
Copy link
Member

@kathrynsilvaconway This actually looks to be correct. The issues are very similar due to them being "good first issues". The issue for PR #3168 you mentioned above is for issue #2797 which changes the building.yml file. This PR affects the board.yml file

Copy link
Member

@Jaretzbalba Jaretzbalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Olanrewaju-Ak Great job working on this good first issue! I see you were able to change line 4 to "content-type" and remove line 11.

@kathrynsilvaconway
Copy link
Member

@kathrynsilvaconway This actually looks to be correct. The issues are very similar due to them being "good first issues". The issue for PR #3168 you mentioned above is for issue #2797 which changes the building.yml file. This PR affects the board.yml file

Aha! Nice catch, as always, @Jaretzbalba. My mistake. I'm going to delete my first review and just write a another one with approval to avoid confusion.

@kathrynsilvaconway kathrynsilvaconway self-requested a review May 24, 2022 02:31
Copy link
Member

@kathrynsilvaconway kathrynsilvaconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Olanrewaju-Ak Congrats on completing your first issue with Hack for LA. I see that you have changed the content field in line 4 to read 'content-type: image' and you have deleted line 11 from the board yml file. Nice work.

@Jaretzbalba Jaretzbalba merged commit e7626fc into hackforla:gh-pages May 24, 2022
@Olanrewaju-Ak Olanrewaju-Ak deleted the edit-contentfield-2794 branch May 29, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging this pull request may close these issues.

Edit content field and remove type field from board.yml credits file
3 participants