Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated value for alt text for the voices neighborhood img #3163

Merged

Conversation

geedtd
Copy link
Member

@geedtd geedtd commented May 20, 2022

Fixes #3105

What changes did you make and why did you make them ?

-changed line #54 on the assets/pages/citizen engagement to reflect requested format that adheres to WCAG

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

…hood council image on citizen engagement page
@github-actions github-actions bot added P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels May 20, 2022
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b geedtd-change-alt-text-council-img-3105 gh-pages
git pull https://github.com/geedtd/website.git change-alt-text-council-img-3105

@answebdev answebdev self-requested a review May 21, 2022 00:18
@answebdev
Copy link
Member

ETA: 5/20/2022 (end of day)
Availability: 2 hours

Copy link
Member

@answebdev answebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your PR. @geedtd For this issue, the alt text in pages/citizen-engagement.html (line 54) needed to be changed, which I can see that you did. I was also able to see this change locally in the dev tools. Great job with that!

Also, please be sure to add this PR to the Project Board. Thank you.

@geedtd
Copy link
Member Author

geedtd commented May 21, 2022

@answebdev sorry about that, I added it to the Project Board. Thanks for the review!

@answebdev
Copy link
Member

@geedtd No problem. Thank you for adding it to the Project Board.

@harshitasao harshitasao self-requested a review May 21, 2022 05:27
@harshitasao
Copy link
Member

Availability: 1 hour
Review ETA: 21/05/2022

Copy link
Member

@harshitasao harshitasao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @geedtd. Changes look good to me.

@answebdev answebdev merged commit d16d1b2 into hackforla:gh-pages May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging this pull request may close these issues.

Change alt text for voices neighborhood council image in citizen engagement html file
4 participants