Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added program area 2384 #2944

Closed

Conversation

KazushiR
Copy link
Member

@KazushiR KazushiR commented Mar 9, 2022

Fixes #2384

What changes did you make and why did you make them ?

-added in program-area

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes

No visual changes

Visuals before changes are applied

image

Visuals after changes are applied

No visual changes

@KazushiR KazushiR self-assigned this Mar 9, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b KazushiR-Added-program-area-2384 gh-pages
git pull https://github.com/KazushiR/website.git Added-program-area-2384

@Sparky-code
Copy link
Member

@KazushiR Can you edit your PR to reference the issue being fixed on the first line, this should allow all the automated tests to pass.
'Fixes #__________'

Is this the same issue? It looks as though this issue is open and still pending changes elsewhere.

Copy link
Member

@SAUMILDHANKAR SAUMILDHANKAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KazushiR: This looks like a duplicate of #2790. Ideally the changes should be made in the original PR itself. You would need to make another commit to #2790 that would resolve the conflicts. Once that PR is merged, we can close this PR.

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Mar 11, 2022
@SAUMILDHANKAR
Copy link
Member

@KazushiR Just noting what we discussed during our team meeting yesterday. This PR should be closed, and changes should be made in #2790. Thank you.

@blulady blulady self-requested a review March 15, 2022 21:01
@KazushiR KazushiR closed this Mar 16, 2022
@blulady blulady removed their request for review June 26, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Program Area to Jobs for Hope Project Details
4 participants