Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 2 lines in CONTRIBUTING.md for better understanding #2659 #2884

Closed
wants to merge 3 commits into from
Closed

Conversation

usaboo
Copy link
Member

@usaboo usaboo commented Feb 24, 2022

Fixes #2659

What changes did you make and why did you make them ?

-Changed line 40 in CONTRIBUTING.md from

      - [**2.3.e What if you don't see any bugs/errors that is not connected to an issue?**](#23e-what-if-you-dont-see-any-bugserrors-that-is-not-connected-to-an-issue)

to

      - [**2.3.e What if you see bugs/errors that are not connected to an issue?**](#23e-what-if-you-see-bugserrors-that-are-not-connected-to-an-issue)

-Changed link 390 in CONTRIBUTING.md from

#### **2.3.e What if you don't see any bugs/errors that is not connected to an issue?**

to

#### **2.3.e What if you see bugs/errors that are not connected to an issue?**

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the actual website but changes to the CONTRIBUTING.md used on github.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b usaboo-gh-pages gh-pages
git pull https://github.com/usaboo/website.git gh-pages

@github-actions github-actions bot added Feature: Onboarding/Contributing.md good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours labels Feb 24, 2022
@1anya1 1anya1 self-requested a review February 25, 2022 21:48
Copy link
Member

@JessicaLucindaCheng JessicaLucindaCheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@usaboo Thanks for working on this issue! As we discussed on Thursday during office hours, the "from" branch should be your topic branch and not your gh-pages. I'm referring to this:
Screenshot 2022-02-26 110214

This is important because your gh-pages branches should match the Hack for LA's gh-pages and not include other commits. If you have other commits on your gh-pages branch, then every time you make a new topic branch based on your gh-pages branch, you can encounter problems when you open prs and see files changed that are not part of the issue you are working on.

I'm going to request you open a new pr with your changes on a topic branch. For now, I will close this pr.

Also, when you open your new pr, please add your pr to the Project Board. If needed, I have included detailed instructions for how to do so:

Click here for more detailed instructions on how to add your pr to the Project Board
  1. On the right, under the "Projects" section
    how-to-add-to-the-project-board1

  2. Click on the gear icon
    Add-to-project-board

  3. Then click on Project Board to add your pull request to the project board.
    how-to-add-to-the-project-board3

@usaboo
Copy link
Member Author

usaboo commented Feb 26, 2022

Hi Jessica, I understand where I was going wrong, I will work on it again, and hopefully have the right PR request before tomorrow's meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Onboarding/Contributing.md good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a sentence easier to understand in CONTRIBUTING.md
3 participants