Merging work from pr #2672 and pr #2724 into gh-pages #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added css grid to technologies dropdown * added media queries for min-width 768 & min-width 1024 * removed redundant css from min-width 1024 * updated comments * removed comment out css * added variables $bp-tablet-up} & $bp-desktop-up * added scrollbar * updated height for desktop * changes to account for Surface Duo Screen 540px * added layout for ipad air with comments * changed $bp-ipadair-up to $bp-ipadair-up
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
Feature: Refactor CSS
|
Review ETA: Now |
SAUMILDHANKAR
approved these changes
Feb 6, 2022
There was a problem hiding this comment.
@JessicaLucindaCheng Thank you for doing all the work related to this issue. Dropdown looks good in my environment and the scroll bar functionality has been implemented as well. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2397
Note to reviewer: The two commits in this pr have already been reviewed in their individual prs, so I don't think anything will break. However, please review the changes in this pr as a whole and check that nothing breaks when these are merged to gh-pages. If there are problems with the changes that break the website or break the functionality/usability of the tech dropdown, please let me know.
What is the purpose of this pull request?
This pull request is to merge the changes made in pr #2672 and pr #2724 (that are currently on the continuation-of-tech-dropdown-pr-2672 branch) into gh-pages. See pr #2672 and pr #2724 for details on the actual changes that would be merged.
Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)
See pr #2672 and pr #2724.