Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon no sql 2669 #2736

Closed
wants to merge 5 commits into from
Closed

Conversation

Pauljsyi
Copy link
Member

@Pauljsyi Pauljsyi commented Feb 4, 2022

Fixes #2669

What changes did you make and why did you make them ?

-added a NoSQL svg file inside the directory name technologies-icons

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

N/A

Visuals after changes are applied

N/A

@Pauljsyi Pauljsyi requested a review from daniellex0 February 4, 2022 02:33
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Pauljsyi-add-icon-NoSQL-2669 gh-pages
git pull https://github.com/Pauljsyi/website.git add-icon-NoSQL-2669

@github-actions github-actions bot added Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Feb 4, 2022
@SAUMILDHANKAR SAUMILDHANKAR removed the request for review from daniellex0 February 5, 2022 06:45
@SAUMILDHANKAR
Copy link
Member

Review ETA: EOD 2/5/22
Availability: 3-6 PM Pacific Saturday

Copy link
Member

@SAUMILDHANKAR SAUMILDHANKAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pauljsyi Hi Paul, Thanks for working on this issue. Request to make the following changes:

  • Please add your PR to the project board.
  • Please edit the description of what changes you made such that it mentions that you removed non svg icons from google drive
  • Please remove the react icon with png extension in the google drive folder
  • Please make sure the changes in expunge-assist.md file and onesheet.pdf file are not visible in the files changed tab.

Once you are done with the changes, please request a re-review. Thank you.

@Pauljsyi
Copy link
Member Author

Pauljsyi commented Feb 7, 2022

ETA: 1 hour
Availability: Tues 3pm

@SAUMILDHANKAR
Copy link
Member

SAUMILDHANKAR commented Feb 17, 2022

@Pauljsyi Thanks for making the changes. I see some of the items are still pending and wanted to follow up on your progress. In regard to the last item on the above checklist, you can try updating your forked gh-pages and merging the updated forked gh-pages into your topic branch. Also, if you have any questions or need help, please add help wanted label or you can reach out on our hfla-site slack channel. Thank you.

@SAUMILDHANKAR
Copy link
Member

@Pauljsyi Hope you are doing well. Just wanted to share one of the decisions made during our team meeting. We are now requesting all website team members to attend at least one meeting in a week (Tuesday, Thursday or Sunday) as we strive to replicate a professional working environment within our team amongst other things. Therefore, request you to let us know which of the weekly meetings would be suitable for you based on availability. We have decided to make an exception for this requirement only on a case-by-case basis. I will leave a message for you on slack as well. Thank you.

@SAUMILDHANKAR
Copy link
Member

SAUMILDHANKAR commented Mar 5, 2022

@Pauljsyi Just wanted to follow up regarding your progress on this issue. Please let us know if you have any questions or need help. Sent a slack message and email as well about the same. Thanks.

@SAUMILDHANKAR
Copy link
Member

@Pauljsyi Planning to close this PR due to inactivity. Please feel free to pick up this or any other issue once your availability changes. Will let you know on slack as well. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add svg icon for NoSQL to the website repo and delete non svg icons from Google Drive folder
2 participants