Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tech dropdown 2397 #2672

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions _sass/components/_project-filter.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@ a.filter-item {
//filter container
ul.filter-list {
background: $color-pink;
display: grid;
list-style: none;
padding-left: 0;
grid-auto-flow: column;
list-style: none;
display: grid;
JessicaLucindaCheng marked this conversation as resolved.
Show resolved Hide resolved
grid-column-gap: 20px;
// grid-template-columns: repeat(4, 1fr);
// ^ See issue #1997 for more info on why this is commented out and changed to 3
Expand Down Expand Up @@ -165,6 +164,36 @@ a.clear-filter-tags {
ul.filter-list li ul {
width: 105%;
padding: 15px;
overflow: auto;
}
}
// tablet down
@media #{$bp-below-tablet} {
#technologies {
height: 370px;
overflow: auto;
}
}

// tablet up
@media #{$bp-tablet-up} {
#technologies {
display: grid;
grid-auto-flow: column; // flows the data from top to bottom rather than left to right
grid-template-rows: repeat(16, 1fr); // ensures the list is 16 rows
list-style: none;
left: -17em;
width: 718px;
height: 380px;
overflow: auto;
}
}

// iPad Air to Desktop
@media #{$bp-desktop-up} {
#technologies {
left: -18em;
width: 768px;
}
}

Expand Down
12 changes: 10 additions & 2 deletions _sass/variables/_layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,24 @@ $screen-mobile: 480px;
* Breakpoint Start and End Declaration
*
* These are generally used for declaring media queries.
* As an example, if a developer wants to make a media query for
* anything above a tablet, use the variable $bp-tablet-up. For
* As an example, if a developer wants to make a media query for
* anything above a tablet, use the variable $bp-tablet-up. For
* anything below a tablet, use $bp-below-tablet.
*/

// Desktop Large
$bp-desktop-large-up: '(min-width: #{$screen-desktop-large})';
$bp-below-desktop-large: '(max-width: #{$screen-desktop-large - 1})';

// Desktop
$bp-desktop-up: '(min-width: #{$screen-desktop})';
$bp-below-desktop: '(max-width: #{$screen-desktop - 1})';

// Tablets
$bp-tablet-up: '(min-width: #{$screen-tablet})';
$bp-below-tablet: '(max-width: #{$screen-tablet - 1})';

// Mobile
$bp-mobile-up: '(min-width: #{$screen-mobile})';
$bp-below-mobile: '(max-width: #{$screen-mobile - 1})';

Expand Down