-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Languages to Filter #2646
Add Languages to Filter #2646
Conversation
…number of projects for each
…category counters for technologies not correctly displaying or filtering
…taset include language info; finally got it working B)
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: EOD 1/5/22 |
I checked mobile responsiveness and adding the languages to the dropdown makes it extend past the footer into white space. Should we kick this back to design or just add a scroll bar? |
@sydneywalcoff please add a scroll bar so that we can push this out. Literally tonight someone asked if there is a project that uses python and they could not search the site. We can always make it look pretty later. |
@sydneywalcoff I see the filter name as Technologies when clicking on Python. Not a major issue but just wondering if it could be changed to languages /technologies or better yet languages? |
The reason I did this was because of the comment on line 23; 'languages / technologies' would not be an appropriate html attribute because of the spaces. They did something similar with 'Program Areas'. It displays as 'Programs'. I figured that 'Technologies' was a more inclusive term than 'Languages'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this needs to be taken care of asap. I have created some notes for this, but will save for Sunday meeting.
Thanks for you work @sydneywalcoff.
Cheers,
- Tomas
Fixes #2488
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied