Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Languages to Filter #2646

Merged

Conversation

sydneywalcoff
Copy link
Member

Fixes #2488

What changes did you make and why did you make them ?

  • added the applicable languages to the filter using the github data
  • changed the filter title to be " languages / technologies"
  • added the languages to data-technologies attribute

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

screenshot showing all cards because language filter not possible and language not displayed on card

Visuals after changes are applied

screenshot showing filtering for 'CSS' and languages displayed on each project card

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b sydneywalcoff-add-languages-to-filter-2488 gh-pages
git pull https://github.com/sydneywalcoff/website.git add-languages-to-filter-2488

@github-actions github-actions bot added P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers Complexity: Medium Status: Updated No blockers and update is ready for review labels Dec 30, 2021
@SAUMILDHANKAR
Copy link
Member

Review ETA: EOD 1/5/22
Availability: 6 hrs

@sydneywalcoff
Copy link
Member Author

I checked mobile responsiveness and adding the languages to the dropdown makes it extend past the footer into white space. Should we kick this back to design or just add a scroll bar?

@ExperimentsInHonesty
Copy link
Member

@sydneywalcoff please add a scroll bar so that we can push this out. Literally tonight someone asked if there is a project that uses python and they could not search the site. We can always make it look pretty later.

@SAUMILDHANKAR
Copy link
Member

Dropdown extends past the footer into white space in current site as well. So, that can be fixed in a separate issue
filter extending into whitespace on mobile view (current site)
.

@SAUMILDHANKAR
Copy link
Member

@sydneywalcoff I see the filter name as Technologies when clicking on Python. Not a major issue but just wondering if it could be changed to languages /technologies or better yet languages?
Technology filter

@sydneywalcoff
Copy link
Member Author

@SAUMILDHANKAR

@sydneywalcoff I see the filter name as Technologies when clicking on Python. Not a major issue but just wondering if it could be changed to languages /technologies or better yet languages? Technology filter

The reason I did this was because of the comment on line 23; 'languages / technologies' would not be an appropriate html attribute because of the spaces. They did something similar with 'Program Areas'. It displays as 'Programs'. I figured that 'Technologies' was a more inclusive term than 'Languages'.

Copy link
Member

@R-Tomas-Gonzalez R-Tomas-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this needs to be taken care of asap. I have created some notes for this, but will save for Sunday meeting.

Thanks for you work @sydneywalcoff.

Cheers,

  • Tomas

@R-Tomas-Gonzalez R-Tomas-Gonzalez merged commit 539c71b into hackforla:gh-pages Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers Status: Updated No blockers and update is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add languages to the technologies project filter
4 participants