Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Program area to Green Earth OS #2643

Closed
wants to merge 1 commit into from

Conversation

jnmrles
Copy link
Member

@jnmrles jnmrles commented Dec 29, 2021

Fixes #2271

What changes did you make and why did you make them ?

  • added program area to green-earth-os.md

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jnmrles-add-program-area-2271 gh-pages
git pull https://github.com/jnmrles/website.git add-program-area-2271

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers Size: Good second issue labels Dec 29, 2021
@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Dec 29, 2021

Review ETA: Thursday, December 30, 2021

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Dec 30, 2021

@jnmrles

  • On the right, under Projects , please add your pull request to the Project Board.

  • Also, please add the following section in your original post/comment and edit it with your before and after changes are applied images:

### Screenshots of Proposed Changes Of The Website  (if any, please do not screen shot code changes)
<!-- Note, if your images are too big, use the <img src="" width="" length="" />  syntax instead of ![image](link) to format the images -->
<!-- If images are not loading properly, you might need to double check the syntax or add a newline after the closing </summary> tag -->

<details>
  <summary>Visuals before changes are applied</summary>

  ![image](Paste_Your_Image_Link_Here_After_Attaching_Files)

</details>

<details>
  <summary>Visuals after changes are applied</summary>

  ![image](Paste_Your_Image_Link_Here_After_Attaching_Files)

</details>

See Complete pull request (4): Include images (if available) in CONTRIBUTING.md for more details.

@anthonysim
Copy link
Member

anthonysim commented Dec 30, 2021

Review ETA: Thursday, Jan 1, 2022

Copy link
Member

@anthonysim anthonysim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnmrles, LGTM! But waiting for the requests from @JessicaLucindaCheng to be made before I give an approval. Good job!

@anthonysim anthonysim self-requested a review January 5, 2022 02:23
@lopezpedres lopezpedres self-requested a review January 5, 2022 23:28
@lopezpedres
Copy link
Member

Review ETA: Jan 7, 2022

@JessicaLucindaCheng JessicaLucindaCheng removed their request for review January 5, 2022 23:39
Copy link
Member

@lopezpedres lopezpedres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! @jnmrles thanks for pointing out the missing part in the PR comment @JessicaLucindaCheng. Looks ready to be merged once the corrections are done :)

@JessicaLucindaCheng
Copy link
Member

@jnmrles

  • On the right, under Projects , please add your pull request to the Project Board.
  • Also, please add the following section in your original post/comment and edit it with your before and after changes are applied images:
### Screenshots of Proposed Changes Of The Website  (if any, please do not screen shot code changes)
<!-- Note, if your images are too big, use the <img src="" width="" length="" />  syntax instead of ![image](link) to format the images -->
<!-- If images are not loading properly, you might need to double check the syntax or add a newline after the closing </summary> tag -->

<details>
  <summary>Visuals before changes are applied</summary>

  ![image](Paste_Your_Image_Link_Here_After_Attaching_Files)

</details>

<details>
  <summary>Visuals after changes are applied</summary>

  ![image](Paste_Your_Image_Link_Here_After_Attaching_Files)

</details>

See Complete pull request (4): Include images (if available) in CONTRIBUTING.md for more details.

@jnmrles Just following up to see if you had questions or need help with making the above requested changes.

The visual changes will be on the Projects page's Green Earth OS card.

Here is where you will see changes: Green-Earth-OS

@JessicaLucindaCheng
Copy link
Member

@jnmrles Are you still interested in working on this issue? If yes, please let me know by Monday, January 31, 2022. If I do not hear back from you by that date, I will close this pull request and unassign you from this issue.

@anthonysim anthonysim removed their request for review January 26, 2022 22:30
@anthonysim
Copy link
Member

I removed myself as reviewer since this is still in-progress.

@JessicaLucindaCheng
Copy link
Member

Closing this pr because I have not heard back from Jovanni.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Program Area: Green Earth OS
5 participants