Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how 'Overview' link opens for Civic Opportunity #2564

Conversation

sydneywalcoff
Copy link
Member

Fixes #2236

What changes did you make and why did you make them ?

  • downloaded and placed pdf in assets/pdfs
  • change the Overview link in the markdown to point to the pdf
  • checked that the link correctly redirects to the pdf from the projects page and the single project page

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No style changes; Just redirected a link.

@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b sydneywalcoff-update-civic-opp-overview-link-2236 gh-pages
git pull https://github.com/sydneywalcoff/website.git update-civic-opp-overview-link-2236

Copy link
Member

@R-Tomas-Gonzalez R-Tomas-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sydneywalcoff / Sydney,

First off thank you for your contribution. May you please make the following changes?

  1. Please change the file name of the pdf to Civic-Opportunity-Project-One-Sheet.pdf
    Note: When you use "."'s for file names can potentially cause issues when programs try to read your file. Using the "-" in file names will help clear that up.
  2. The correct url path should be: "/assets/pdfs/Civic-Opportunity-Project-One-Sheet.pdf"

Thanks again.
Cheers,

Tomas | Slack - DM

Copy link
Member

@R-Tomas-Gonzalez R-Tomas-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you. And congratulations on your merge! :)

@R-Tomas-Gonzalez R-Tomas-Gonzalez merged commit 557ff50 into hackforla:gh-pages Dec 9, 2021
@JessicaLucindaCheng JessicaLucindaCheng removed their request for review December 9, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: front end Tasks for front end developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update how 'Overview' link opens for Civic Opportunity
3 participants