-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated overview link opens Access The Data-2234 #2549
updated overview link opens Access The Data-2234 #2549
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
I am not sure why one of the checks are failing?
I will bring this up at Tues meeting and see if I can fix it. Edit: NVM, I figured it out, I forgot to update the Fixes: #2234 portion of the PR message above. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anthonysim Under the "Screenshots of Proposed Changes Of The Website" for the pull request comment, if there are no images, please add an explanation for why there are no images. See the example in the bottom of the section iv. Complete pull request (4): Include images (if available). Thanks.
Otherwise, good job! The Access the Data PDF was added to the correct folder (assets/pdf) and the url was changed in the access-the-data.md file to open the PDF file in the browser.
I meant to just comment. Waiting on images section of PR comment to be updated.
@JessicaLucindaCheng, oops, I just added the missing screenshots! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anthonysim Thanks for adding the screenshots to the pull request comment! Everything looks good now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Great job Anthony!
Fixes #2234
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied