Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated overview link opens Access The Data-2234 #2549

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

anthonysim
Copy link
Member

@anthonysim anthonysim commented Dec 6, 2021

Fixes #2234

What changes did you make and why did you make them ?

  • Download a copy of Access The Data's overview pdf and put it in /assets/pdfs
  • Change the 'Overview' link for the markdown file to point to the pdf file living under /assets/pdfs
  • Ensure that the links in both the project page and the project's dedicated page open the pdf file properly after the change

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied
Visuals after changes are applied

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b anthonysim-update-overview-2234 gh-pages
git pull https://github.com/anthonysim/website.git update-overview-2234

@anthonysim
Copy link
Member Author

anthonysim commented Dec 6, 2021

I am not sure why one of the checks are failing?

Set PR Labels / generate-labels-artifact (pull_request)

I will bring this up at Tues meeting and see if I can fix it.

Edit: NVM, I figured it out, I forgot to update the Fixes: #2234 portion of the PR message above.

@github-actions github-actions bot added Feature: Refactor HTML role: front end Tasks for front end developers Size: Good second issue Status: Updated No blockers and update is ready for review labels Dec 6, 2021
@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Dec 8, 2021

  • Availability: Wed, Dec 8, 2021 7am-5pm PST
  • Review ETA: Wed, Dec 8, 2021

Copy link
Member

@JessicaLucindaCheng JessicaLucindaCheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anthonysim Under the "Screenshots of Proposed Changes Of The Website" for the pull request comment, if there are no images, please add an explanation for why there are no images. See the example in the bottom of the section iv. Complete pull request (4): Include images (if available). Thanks.

Otherwise, good job! The Access the Data PDF was added to the correct folder (assets/pdf) and the url was changed in the access-the-data.md file to open the PDF file in the browser.

@JessicaLucindaCheng JessicaLucindaCheng dismissed their stale review December 9, 2021 01:53

I meant to just comment. Waiting on images section of PR comment to be updated.

@anthonysim
Copy link
Member Author

anthonysim commented Dec 9, 2021

@anthonysim Under the "Screenshots of Proposed Changes Of The Website" for the pull request comment, if there are no images, please add an explanation for why there are no images. See the example in the bottom of the section iv. Complete pull request (4): Include images (if available). Thanks.

Otherwise, good job! The Access the Data PDF was added to the correct folder (assets/pdf) and the url was changed in the access-the-data.md file to open the PDF file in the browser.

@JessicaLucindaCheng, oops, I just added the missing screenshots!

Copy link
Member

@JessicaLucindaCheng JessicaLucindaCheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anthonysim Thanks for adding the screenshots to the pull request comment! Everything looks good now!

Copy link
Contributor

@Johnnie007 Johnnie007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Great job Anthony!

@macho-catt macho-catt merged commit ea1ea4a into hackforla:gh-pages Dec 10, 2021
@anthonysim anthonysim deleted the update-overview-2234 branch December 10, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: front end Tasks for front end developers Status: Updated No blockers and update is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update how 'Overview' link opens for Access The Data
5 participants