Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed getting started FAQ with updated text. also re-added css that was removed #2338

Merged
merged 1 commit into from
Oct 12, 2021
Merged

fixed getting started FAQ with updated text. also re-added css that was removed #2338

merged 1 commit into from
Oct 12, 2021

Conversation

aalieu
Copy link
Member

@aalieu aalieu commented Oct 5, 2021

Fixes #1619

What changes did you make and why did you make them ?

  • Updated the FAQ text to what was shown in Figma
  • Re-added CSS that may have been accidentally removed in another PR that fixes the styling of the FAQ header and github
    signup text

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

prev faq with deleted css

Visuals after changes are applied

updated FAQ with css back

@github-actions github-actions bot added P-Feature: Getting Started https://www.hackforla.org/getting-started role: front end Tasks for front end developers Complexity: Large Status: Updated No blockers and update is ready for review labels Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b aalieu-fix-getting-started-faq-text gh-pages
git pull https://github.com/aalieu/website.git fix-getting-started-faq-text

@abuna1985 abuna1985 mentioned this pull request Oct 10, 2021
Open
17 tasks
abuna1985
abuna1985 approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@abuna1985 abuna1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aalieu Thank you for your pull request! I was able to pull down the branch and verify the changes have updated the Getting Started page. I am approving this PR and will merge it. Keep up the good work! 🌠 🌠 🌠

@abuna1985 abuna1985 merged commit 055674d into hackforla:gh-pages Oct 12, 2021
@abuna1985 abuna1985 added the hacktoberfest-accepted Makes a pull request be counted as verified and valid label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abuna1985 abuna1985 abuna1985 approved these changes

Assignees
No one assigned
Labels
Complexity: Large hacktoberfest-accepted Makes a pull request be counted as verified and valid P-Feature: Getting Started https://www.hackforla.org/getting-started role: front end Tasks for front end developers Status: Updated No blockers and update is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop Updated Getting Started page
2 participants
@aalieu @abuna1985