-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix header bug #2281
Fix header bug #2281
Conversation
From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glenflorendo Great work. I was able to pull the changes locally and verify the hero/header sections are centered again on the 8 pages listed. Great work. Thank you for your efficient solution! 🎉 🎉 🎉
need further research to see if a better solution can be made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glenflorendo Great job on creating a solution to resolve the header/hero alignment. I have added comments within the pull request changes. But to reiterate:
- revert the change from line 14 of
_sass/elements/containers.scss
and add backmargin-right: 5em
; - Delete
.header-text
styling from line 83-91
website/_sass/elements/_containers.scss
Lines 83 to 91 in 62efccd
.header-text { | |
font-size: 26px; | |
display: flex; | |
max-width: 895px; | |
text-align: center; | |
padding: 30px; | |
margin: 12px auto; | |
font-family: "Roboto" sans-serif; | |
} |
As soon as these changes are made, I will complete another review.
Thank you!
@abuna1985 @arghmatey Changes done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glenflorendo Excellent work. I was able to verify the changes have corrected the header title/text/image sections for the 8 pages listed. Thank you for responding so quickly! 🎉 🎉 🎉
Fixes #2269
What changes did you make and why did you make them ?
header-text
class to properly center the header description and imagePlease note that this change affects the following:
Screenshots of Proposed Changes (Before vs After)
about
communities-of-practice
credits
join
program-areas
project-meetings
sitemap
toolkit