Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header bug #2281

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Fix header bug #2281

merged 2 commits into from
Sep 17, 2021

Conversation

glenflorendo
Copy link
Member

Fixes #2269

What changes did you make and why did you make them ?

  • Remove margins for header-text class to properly center the header description and image

Please note that this change affects the following:

File Web Page
pages/about.html https://www.hackforla.org/about
pages/communities-of-practice.html https://www.hackforla.org/communities-of-practice
pages/credits.html https://www.hackforla.org/credits
pages/join-us.html https://www.hackforla.org/join
pages/program-areas.html https://www.hackforla.org/program-areas
pages/project-meetings.html https://www.hackforla.org/project-meetings
pages/sitemap.html https://www.hackforla.org/sitemap
pages/toolkit.html https://www.hackforla.org/toolkit

Screenshots of Proposed Changes (Before vs After)

about about

about_change

communities-of-practice

communities-of-practice

communities-of-practice_change

credits

credits

credits_change

join

join

join_change

program-areas

program-areas

program-areas_change

project-meetings

project-meetings

project-meetings_change

sitemap

sitemap

sitemap_change

toolkit

toolkit

toolkit_change

@github-actions github-actions bot added Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages Feature: Refactor HTML role: front end Tasks for front end developers Complexity: Medium time sensitive Needs to be worked on by a particular timeframe labels Sep 16, 2021
@github-actions
Copy link

From your project repository, check out a new branch and test the changes.

git checkout -b glenflorendo-2269-header-bug gh-pages
git pull https://github.com/glenflorendo/website.git 2269-header-bug

abuna1985
abuna1985 previously approved these changes Sep 16, 2021
Copy link
Member

@abuna1985 abuna1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glenflorendo Great work. I was able to pull the changes locally and verify the hero/header sections are centered again on the 8 pages listed. Great work. Thank you for your efficient solution! 🎉 🎉 🎉

@abuna1985 abuna1985 dismissed their stale review September 17, 2021 00:15

need further research to see if a better solution can be made.

@abuna1985 abuna1985 self-requested a review September 17, 2021 00:15
Copy link
Member

@abuna1985 abuna1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glenflorendo Great job on creating a solution to resolve the header/hero alignment. I have added comments within the pull request changes. But to reiterate:

  1. revert the change from line 14 of _sass/elements/containers.scss and add back margin-right: 5em;
  2. Delete .header-text styling from line 83-91

.header-text {
font-size: 26px;
display: flex;
max-width: 895px;
text-align: center;
padding: 30px;
margin: 12px auto;
font-family: "Roboto" sans-serif;
}

As soon as these changes are made, I will complete another review.

Thank you!

_sass/elements/_containers.scss Outdated Show resolved Hide resolved
_sass/elements/_containers.scss Outdated Show resolved Hide resolved
@abuna1985 abuna1985 self-requested a review September 17, 2021 00:46
@glenflorendo
Copy link
Member Author

@glenflorendo Great job on creating a solution to resolve the header/hero alignment. I have added comments within the pull request changes. But to reiterate:

  1. revert the change from line 14 of _sass/elements/containers.scss and add back margin-right: 5em;
  2. Delete .header-text styling from line 83-91

.header-text {
font-size: 26px;
display: flex;
max-width: 895px;
text-align: center;
padding: 30px;
margin: 12px auto;
font-family: "Roboto" sans-serif;
}

As soon as these changes are made, I will complete another review.

Thank you!

@abuna1985 @arghmatey Changes done!

Copy link
Member

@abuna1985 abuna1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glenflorendo Excellent work. I was able to verify the changes have corrected the header title/text/image sections for the 8 pages listed. Thank you for responding so quickly! 🎉 🎉 🎉

@abuna1985 abuna1985 merged commit a159ab4 into hackforla:gh-pages Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages Feature: Refactor HTML role: front end Tasks for front end developers time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix header bug
2 participants