Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardization of the accordion element #2208

Merged
merged 6 commits into from
Sep 15, 2021
Merged

Standardization of the accordion element #2208

merged 6 commits into from
Sep 15, 2021

Conversation

JackRichman
Copy link
Member

@JackRichman JackRichman commented Aug 30, 2021 •
edited by Aveline-art
Loading

Fixes #1407

What changes did you make and why did you make them ?

  • moved js code from html files to accordion.js
  • moved css styling for accordion from multiple files to _accordion.scss

@JackRichman
Copy link
Member Author

@hackforla/website-merge converted this pull request to draft. Awaiting resolution from this comment: #1407 (comment)

@abuna1985 abuna1985 marked this pull request as ready for review August 31, 2021 05:00
@abuna1985 abuna1985 marked this pull request as draft August 31, 2021 05:01
@macho-catt
Copy link
Member

macho-catt commented Sep 5, 2021 •
edited
Loading

@JackRichman do you have any more questions, and if not can this be undrafted? Thanks :)

@abuna1985 abuna1985 marked this pull request as ready for review September 12, 2021 18:28
abuna1985
abuna1985 suggested changes Sep 12, 2021
View reviewed changes
Copy link
Member

@abuna1985 abuna1985 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackRichman My apologies for the delay. There seem to be merge conflicts that need to be addressed. You can follow the Check Upstream before you push instructions. If you need any help, please reach out to me on Slack or come to a dev meeting. Thank you.

Also, can you change care.yml back to give.yml? You can find it at _data/internal/credits/care.yml

@adrian-zaragoza adrian-zaragoza mentioned this pull request Sep 12, 2021
Open
17 tasks
@abuna1985 abuna1985 added role: front end Tasks for front end developers Complexity: Large P-Feature: Toolkit https://www.hackforla.org/toolkit/ labels Sep 13, 2021
@github-actions github-actions bot added To Update ! No update has been provided UAT: has visuals labels Sep 13, 2021
abuna1985
abuna1985 approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@abuna1985 abuna1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackRichman Great job solving the merge conflicts. I have pulled the changes and verified the accordion works on the Getting Started page and the Guide Pages 2FA page correctly. Great job. Thank you for your patience with this pull request.

macho-catt
macho-catt approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@macho-catt macho-catt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job!

@macho-catt macho-catt merged commit 7e51ed8 into hackforla:gh-pages Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macho-catt macho-catt macho-catt approved these changes

@abuna1985 abuna1985 abuna1985 approved these changes

Assignees
No one assigned
Labels
Complexity: Large P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers To Update ! No update has been provided UAT: has visuals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accordion Component Standardization
4 participants
@JackRichman @macho-catt @abuna1985 @adrian-zaragoza