Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored the lines for button styling in join-us page #2196

Merged

Conversation

mehmehmehlol
Copy link
Contributor

Fixes #2165

What changes did you make and why did you make them ?

  • I refactored the lines that are stated in the issue
  • Added an additional variable, .btn--default on _buttons.scss from website/_sass/elements after inquiring @abuna1985
  • Note: After refactoring, the buttons did not appear as they were originally on my browser. I would attach the screenshot under the section of "visuals after change". I had reached out to @abuna1985 with my concerns. It appeared the refactoring did not make the drastic change on Adam's browser like on my browser -- as in the newly added variable on scss did not show up in my inspect. It might just be a minor issue on my end.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Join Us Page Before Refactoring

Visuals after changes are applied

Join Us Page after Refactoring on my browser

@github-actions github-actions bot added Feature: Design system Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue To Update ! No update has been provided labels Aug 28, 2021
@github-actions
Copy link

From your project repository, check out a new branch and test the changes.

git checkout -b mehmehmehlol-join-us-refactor-buttons-2165 gh-pages
git pull https://github.com/mehmehmehlol/website.git join-us-refactor-buttons-2165

@abuna1985 abuna1985 self-requested a review August 29, 2021 06:53
Copy link
Member

@abuna1985 abuna1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehmehmehlol Great job. Thank you for helping with the button implementation and working with me on a resolution to apply the style changes. I only have one request:

  • It seems the class name in the <a> is btn-defualt. Please change it to btn--default and commit/push your changes to update this pull request.

Thank you.

pages/join-us.html Outdated Show resolved Hide resolved
pages/join-us.html Outdated Show resolved Hide resolved
pages/join-us.html Outdated Show resolved Hide resolved
@abuna1985 abuna1985 removed the To Update ! No update has been provided label Aug 29, 2021
@adrian-zaragoza adrian-zaragoza self-requested a review August 29, 2021 18:19
Copy link
Member

@abuna1985 abuna1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehmehmehlol I see the update and everything looks good on the Join page buttons. Great work! 🥳 🥳 🥳

Thank you for helping us with the system design implementation.

Copy link
Member

@adrian-zaragoza adrian-zaragoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good! Thank you!

Copy link
Member

@macho-catt macho-catt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job on this!

@macho-catt macho-catt merged commit b939031 into hackforla:gh-pages Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: front end Tasks for front end developers UAT: has visuals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete refactor/standardization of all buttons within Join Us Page
5 participants