-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored the lines for button styling in join-us page #2196
refactored the lines for button styling in join-us page #2196
Conversation
From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mehmehmehlol Great job. Thank you for helping with the button implementation and working with me on a resolution to apply the style changes. I only have one request:
- It seems the class name in the
<a>
isbtn-defualt
. Please change it tobtn--default
and commit/push your changes to update this pull request.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mehmehmehlol I see the update and everything looks good on the Join page buttons. Great work! 🥳 🥳 🥳
Thank you for helping us with the system design implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good job on this!
Fixes #2165
What changes did you make and why did you make them ?
.btn--default
on_buttons.scss
fromwebsite/_sass/elements
after inquiring @abuna1985Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied