Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust header-container class margin #1852

Merged

Conversation

arghmatey
Copy link
Contributor

Fixes #1791

What changes did you make and why did you make them ?

  • Changed top margin of .header-container to 61px to move most pages header farther away from nav as discussed in original issue
  • Removed or made minor changes to a few pages top margins and padding to accommodate the change to .header-container or to match it if the page doesn't use .header-container

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Toolkit page before

Screen Shot 2021-06-28 at 12 44 20 PM

Toolkit page after

Screen Shot 2021-06-28 at 12 43 45 PM

@HackforLABot HackforLABot added Feature: Design system role: front end Tasks for front end developers Complexity: Medium time sensitive Needs to be worked on by a particular timeframe labels Jun 28, 2021
@arghmatey arghmatey changed the title Adjust header container margin Adjust header-container class margin Jun 28, 2021
@Aveline-art Aveline-art self-requested a review June 29, 2021 23:30
Copy link
Member

@Aveline-art Aveline-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks good! Thank you for putting in the work to check the other pages.

If you happen to still have your notes on the header of all the pages, they might prove useful soon when we start standardizing the css and html of the site. You might want to keep them somewhere, maybe on #1850.

Also, great catch on the How to create a page on the HfLA website wiki page. I think the team should discuss updating that wiki.

@akibrhast
Copy link
Member

@hackforla/website-merge It seems like this has been approved. Should it be merged ? What is the next step?

@Aveline-art Aveline-art merged commit 72d1b5d into hackforla:gh-pages Jul 2, 2021
@Aveline-art
Copy link
Member

@akibrhast Thanks Akib! I couldn't merge it before because I reviewed this before the announcement. I have taken the opportunity to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Design system role: front end Tasks for front end developers time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the margin in header-container class
4 participants